FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.13] gh-117398: Use the correct module loader for iOS in datetime CAPI test (GH-120477) by neonene · Pull Request #121561 · python/cpython · GitHub

/ cpython Public

[3.13] gh-117398: Use the correct module loader for iOS in datetime CAPI test (GH-120477) - #121561

Merged
freakboy3742 merged 1 commit into
python:3.13from
neonene:datetime-capitest
Jul 10, 2024
ConversationCommits (1)ChecksFiles changed
Merged

[3.13] gh-117398: Use the correct module loader for iOS in datetime CAPI test (GH-120477)#121561
freakboy3742 merged 1 commit into
python:3.13from
neonene:datetime-capitest

Conversation

neonene commented Jul 10, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

#119604 added a CAPI test for subinterpreters in the datetime tests; however, the test uses the ExtensionFileLoader to load _testcapi. iOS requires the use of the AppleFrameworkLoader.

(backported from commit 5c58e72, AKA gh-120477)

neonene requested review from abalkin and pganssle as code owners July 10, 2024 01:15
bedevere-app Bot mentioned this pull request Jul 10, 2024
Closed
bedevere-app Bot mentioned this pull request Jul 10, 2024
Merged

This comment was marked as off-topic.

Sign in to view

bedevere-bot commented Jul 10, 2024

Copy link
Copy Markdown

You don't have write permissions to trigger a build

neonene commented Jul 10, 2024

Copy link
Copy Markdown
Contributor Author

@freakboy3742 Could you review the backport? I failed to trigger the iOS build bot.

neonene mentioned this pull request Jul 10, 2024
Merged

freakboy3742 commented Jul 10, 2024

Copy link
Copy Markdown
Contributor

!buildbot iOS

bedevere-bot commented Jul 10, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 987dd52 🤖

The command will test the builders whose names match following regular expression: iOS

The builders matched are:

  • iOS ARM64 Simulator PR

freakboy3742 merged commit c08a302 into python:3.13 Jul 10, 2024

freakboy3742 commented Jul 10, 2024

Copy link
Copy Markdown
Contributor

@neonene Thanks for the backport (and nice work hunting down the fix without access to the buildbot!)

neonene deleted the datetime-capitest branch July 10, 2024 23:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

freakboy3742 freakboy3742 approved these changes
pganssle Awaiting requested review from pganssle pganssle is a code owner
abalkin Awaiting requested review from abalkin abalkin is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL