FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-120671: Fix as_fn_append CFLAGS by allsey87 · Pull Request #120822 · python/cpython · GitHub

/ cpython Public

gh-120671: Fix as_fn_append CFLAGS - #120822

Merged
vstinner merged 2 commits into
python:mainfrom
allsey87:main
Jun 25, 2024
ConversationCommits (2)ChecksFiles changed
Merged

gh-120671: Fix as_fn_append CFLAGS#120822
vstinner merged 2 commits into
python:mainfrom
allsey87:main

Conversation

allsey87 commented Jun 21, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

This fixes an issue with failing configure tests due to a missing space when appending to CFLAGS. @eli-schwartz tracked down the source of this bug as follows:

In commit 76d14fa (GH-29485), some code was refactored to be more compact and use more advanced autoconf tricks. In the process, it switched

AS_VAR_SET([XXX], ["$XXX other values"])

to

AS_VAR_APPEND([XXX], ["other values"])

This was a functional logic break, since it elided the space in between the existing and appended values -- and that space is mandatory for command-line flags stuffed into a variable.

The same problem occurred for LDFLAGS, but was silently fixed as a side effect of commit bb8b931 (GH-32229).

Resolves #120671

bedevere-app Bot mentioned this pull request Jun 21, 2024
Closed

allsey87 commented Jun 21, 2024

Copy link
Copy Markdown
Contributor Author

Note that this issue with a missing space might also be true of configure.ac#L7548.

erlend-aasland self-assigned this Jun 21, 2024
erlend-aasland added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jun 21, 2024

erlend-aasland commented Jun 21, 2024

Copy link
Copy Markdown
Contributor

Note that this issue with a missing space might also be true of configure.ac#L7548.

No, that's not an issue. It's the # that prepends some extension module build variables. See for example Modules/Setup.stdlib.in

erlend-aasland commented Jun 21, 2024

Copy link
Copy Markdown
Contributor

Can you supply a NEWS entry?

vstinner merged commit 2106c9b into python:main Jun 25, 2024

miss-islington-app Bot commented Jun 25, 2024

Copy link
Copy Markdown

Thanks @allsey87 for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 25, 2024
pythongh-120671: Fix PY_CHECK_CC_WARNING() in configure.ac (pythonGH-…
fe2912e 
…120822)

Add missing space in AS_VAR_APPEND() on CFLAGS.
(cherry picked from commit 2106c9b)

Co-authored-by: Michael Allwright <allsey87@gmail.com>

bedevere-app Bot commented Jun 25, 2024

Copy link
Copy Markdown

GH-120985 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jun 25, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 25, 2024
pythongh-120671: Fix PY_CHECK_CC_WARNING() in configure.ac (pythonGH-…
42bec11 
…120822)

Add missing space in AS_VAR_APPEND() on CFLAGS.
(cherry picked from commit 2106c9b)

Co-authored-by: Michael Allwright <allsey87@gmail.com>

bedevere-app Bot commented Jun 25, 2024

Copy link
Copy Markdown

GH-120986 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jun 25, 2024

vstinner commented Jun 25, 2024

Copy link
Copy Markdown
Member

Merged, thanks.

vstinner pushed a commit that referenced this pull request Jun 25, 2024
[3.12] gh-120671: Fix PY_CHECK_CC_WARNING() in configure.ac (GH-120822)…
433a5f8 
… (#120986)

gh-120671: Fix PY_CHECK_CC_WARNING() in configure.ac (GH-120822)

Add missing space in AS_VAR_APPEND() on CFLAGS.
(cherry picked from commit 2106c9b)

Co-authored-by: Michael Allwright <allsey87@gmail.com>
vstinner pushed a commit that referenced this pull request Jun 25, 2024
[3.13] gh-120671: Fix PY_CHECK_CC_WARNING() in configure.ac (GH-120822)…
d26ce50 
… (#120985)

gh-120671: Fix PY_CHECK_CC_WARNING() in configure.ac (GH-120822)

Add missing space in AS_VAR_APPEND() on CFLAGS.
(cherry picked from commit 2106c9b)

Co-authored-by: Michael Allwright <allsey87@gmail.com>
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
pythongh-120671: Fix PY_CHECK_CC_WARNING() in configure.ac (python#12…
02eccfc 
…0822)

Add missing space in AS_VAR_APPEND() on CFLAGS.
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
pythongh-120671: Fix PY_CHECK_CC_WARNING() in configure.ac (python#12…
48eb1f3 
…0822)

Add missing space in AS_VAR_APPEND() on CFLAGS.
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
pythongh-120671: Fix PY_CHECK_CC_WARNING() in configure.ac (python#12…
c49e6d3 
…0822)

Add missing space in AS_VAR_APPEND() on CFLAGS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

zware zware approved these changes
erlend-aasland erlend-aasland approved these changes
corona10 Awaiting requested review from corona10 corona10 is a code owner

Assignees

erlend-aasland

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Failing configure tests due to missing space

4 participants

Back | FazBrowse Home | New Git URL