FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-90005: Port _ctypes to PY_STDLIB_MOD by tiran · Pull Request #32229 · python/cpython · GitHub

/ cpython Public

gh-90005: Port _ctypes to PY_STDLIB_MOD - #32229

Merged
miss-islington merged 13 commits into
python:mainfrom
tiran:bpo-45847-ctypes2
Jun 26, 2022
Merged

gh-90005: Port _ctypes to PY_STDLIB_MOD#32229
miss-islington merged 13 commits into
python:mainfrom
tiran:bpo-45847-ctypes2

Conversation

tiran commented Apr 1, 2022
edited by miss-islington
Loading

Copy link
Copy Markdown
Member

Co-authored-by: Erlend Egeberg Aasland erlend.aasland@innova.no

https://bugs.python.org/issue45847

Automerge-Triggered-By: GH:tiran

Copy link
Copy Markdown
Member

Is is a harbinger of finally devendored libffi? Currently, CPython ships 1.20 (1998) while Debian LTS supplies 3.2.1 (2014).

tiran force-pushed the bpo-45847-ctypes2 branch from 48b7e12 to 1fa02d9 Compare April 1, 2022 12:25

tiran commented Apr 1, 2022

Copy link
Copy Markdown
Member Author

libffi was de-vendored in 3.7 (Linux, BSD) and 3.8 (Windows). We only keep a copy for macos around.

tiran force-pushed the bpo-45847-ctypes2 branch from 4bd87da to cc5cb24 Compare April 1, 2022 12:40
tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 1, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit cc5cb24a3c148b044e5bc2cb606b8a612e6f0440 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 1, 2022

tiran commented Apr 1, 2022

Copy link
Copy Markdown
Member Author

ctypes tests are failing on ARM64 macOS

tiran force-pushed the bpo-45847-ctypes2 branch from cc5cb24 to 54e6b11 Compare April 1, 2022 13:27

tiran commented Apr 1, 2022

Copy link
Copy Markdown
Member Author

I have no clue how the SDK stuff works on macOS. In order to land the PR I would need some assistance from @ned-deily or @ronaldoussoren . Or can we drop the SDK and use system-ffi on all system?

tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 1, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit 54e6b1122be7ab28dc0456516cc4d3f81fc0df7e 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 1, 2022

Copy link
Copy Markdown
Contributor

I'll try to look at the PR over the weekend.

As a general statement I'd prefer to use the system install of libffi on macOS because Apple includes some magic in its version to ensure libffi closures work properly with their code signature system (in particular some magic to ensure that you don't need the "JIT" entitlement to use closures).

tiran force-pushed the bpo-45847-ctypes2 branch from 54e6b11 to 53607e3 Compare April 2, 2022 23:12
tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 2, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit 53607e36d3dd2446103a5d9175b8d3ee1e271e08 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 2, 2022
tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 3, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit e4ab8cf4c4d2bf9156f0551d8df68299ef153295 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 3, 2022
tiran marked this pull request as ready for review April 4, 2022 09:31
tiran force-pushed the bpo-45847-ctypes2 branch from 771527a to d854d7f Compare June 26, 2022 08:00
tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 26, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit d854d7f 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 26, 2022

tiran commented Jun 26, 2022

Copy link
Copy Markdown
Member Author

@ned-deily @ronaldoussoren I would like to merge this PR rather sooner than later into main. It is required to test ctypes on wasm32-emscripten and will allow us to remove setup.py. Tests are passing on macOS.

Comment thread configure.ac Outdated
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>

Copy link
Copy Markdown
Contributor

Status check is done, and it's a success ✅ .

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants


Back | FazBrowse Home | New Git URL