gh-121027: Add a future warning in functools.partial.__get__ - #121086
Merged
Yhg1s merged 2 commits intoJun 27, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Yhg1s
approved these changes
Jun 27, 2024
Yhg1s
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Not really that happy about getting this into 3.13 at this stage, but whatever, it's only a FutureWarning on something that's a bad idea anyway (by which I mean using functools.partial in the first place, as well as using it as a class attribute.)
Sorry, something went wrong.
Comment thread
Doc/whatsnew/3.13.rst
Outdated
Co-authored-by: T. Wouters <thomas@python.org>
Copy link
Copy Markdown
|
Thanks @serhiy-storchaka for the PR, and @Yhg1s for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 27, 2024
…ythonGH-121086) (cherry picked from commit db96edd) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Copy link
Copy Markdown
|
GH-121092 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
Yhg1s
pushed a commit
that referenced
this pull request
Jun 27, 2024
mrahtz
pushed a commit
to mrahtz/cpython
that referenced
this pull request
Jun 30, 2024
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--121086.org.readthedocs.build/