| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
This should have been labeled as "DO-NOT-MERGE" until #121086 was merged. There are conflicts anyway now. |
Sorry, something went wrong.
Co-authored-by: d.grigonis <dgrigonis@users.noreply.github.com>
| get = getattr(self.func, "__get__", None) | ||
| result = None | ||
| if get is not None and not isinstance(self.func, partial): | ||
| if get is not None: |
There was a problem hiding this comment.
It was needed to avoid emitting a warning for partialmethod(partial(...)), even if the final behavior is not changed.
Sorry, something went wrong.
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot AMD64 Ubuntu NoGIL Refleaks 3.x has failed when building commit ff5806c. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/all/#builders/1226/builds/2167 Failed tests:
Failed subtests:
Summary of the results of the build (if available): == Click to see traceback logsTraceback (most recent call last):
File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/test_concurrent_futures/executor.py", line 130, in test_free_reference
self.assertIsNone(wr())
~~~~~~~~~~~~~~~~~^^^^^^
AssertionError: <test.test_concurrent_futures.executor.MyObject object at 0x20002080170> is not None
Traceback (most recent call last):
File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/test_concurrent_futures/executor.py", line 130, in test_free_reference
self.assertIsNone(wr())
~~~~~~~~~~~~~~~~~^^^^^^
AssertionError: <test.test_concurrent_futures.executor.MyObject object at 0x20006090090> is not None
|
Sorry, something went wrong.
pythonGH-121089) Co-authored-by: d.grigonis <dgrigonis@users.noreply.github.com>
pythonGH-121089) Co-authored-by: d.grigonis <dgrigonis@users.noreply.github.com>
PR #121089 added an eager import for types.MethodType, but still left the existing hacks for lazily importing from types. We could also create MethodType internally in functools.py (e.g., by using `type(Placeholder.__repr__)`, but it feels not worth it at this point, so instead I unlazified all the usages of types in the module.
|
May I ask why this change was considered critical enough to not follow PEP 387? It is clearly backwards incompatible and is in fact breaking code, see lark-parser/lark#1480 . |
Sorry, something went wrong.
#2546 is blocked because we don't run the tests on this branch with Python 3.14, but these are configured as required checks. Since Ops 2.23 only specifies Python `>=3.8`, we'd expect it to run fine with Python 3.14. In addition to adding 3.14 to the list of versions in CI, we also need to add it to the list of environments in `tox.ini`, and follow #2091 in patching some of the tests: we now need to wrap our `functools.partial` objects in `staticmethod` due to `partial` implementing the decriptor protocol in Python 3.14 (python/cpython#121027, python/cpython#121089). However, because we're on an older `pyright` version in this maintenance branch, this leads to type checking errors which we ignore (bumping `pyright` resolves this but introduces 20+ other errors which would add noise to this PR).
| Back | FazBrowse Home | New Git URL |
Co-authored-by: d.grigonis dgrigonis@users.noreply.github.com
📚 Documentation preview 📚: https://cpython-previews--121089.org.readthedocs.build/