FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Merge Ubuntu test matrices in CI by webknjaz · Pull Request #121813 · python/cpython · GitHub

/ cpython Public

Merge Ubuntu test matrices in CI - #121813

Merged
hugovk merged 2 commits into
python:mainfrom
webknjaz:maintenance/gha-ubuntu-reusable-collapse
Jul 21, 2024
ConversationCommits (2)ChecksFiles changed
Merged

Merge Ubuntu test matrices in CI#121813
hugovk merged 2 commits into
python:mainfrom
webknjaz:maintenance/gha-ubuntu-reusable-collapse

Conversation

webknjaz commented Jul 15, 2024

Copy link
Copy Markdown
Member

Previously, they were duplicated, with custom commands being passed to the same reusable workflow. This patch moves the commands in and adds a matrix resembling the interface of other OS tests.

🧪💅 Merge Ubuntu test matrices in CI
7b65aaf 
Previously, they were duplicated, with custom commands being passed to
the same reusable workflow. This patch moves the commands in and adds
a matrix resembling the interface of other OS tests.
webknjaz force-pushed the maintenance/gha-ubuntu-reusable-collapse branch from c0e2d29 to 7b65aaf Compare July 15, 2024 21:50

picnixz commented Jul 21, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Should this one have an issue? @hugovk

webknjaz commented Jul 21, 2024

Copy link
Copy Markdown
Member Author

@picnixz no, Hugo will apply respective labels later.

picnixz commented Jul 21, 2024

Copy link
Copy Markdown
Member

I've added the skip issue & skip news labels to this PR and the others that are similar. I'll let Hugo add other labels if needed (I couldn't find one related to CI only)

hugovk changed the title 🧪💅 Merge Ubuntu test matrices in CI Merge Ubuntu test matrices in CI Jul 21, 2024
hugovk reviewed Jul 21, 2024
View reviewed changes
Comment thread .github/workflows/reusable-ubuntu.yml Outdated
Rephrase "no-GIL" as "free-threading"
8ca326f 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
hugovk approved these changes Jul 21, 2024
View reviewed changes

hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you!

hugovk added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes and removed awaiting merge labels Jul 21, 2024
hugovk merged commit a3f7db9 into python:main Jul 21, 2024

miss-islington-app Bot commented Jul 21, 2024

Copy link
Copy Markdown

Thanks @webknjaz for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 21, 2024
Merge Ubuntu test matrices in CI (pythonGH-121813)
f799298 
(cherry picked from commit a3f7db9)

Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

miss-islington-app Bot commented Jul 21, 2024

Copy link
Copy Markdown

Sorry, @webknjaz and @hugovk, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker a3f7db905c5aecda1d06fb60ed382a17e5b9c7aa 3.12

bedevere-app Bot commented Jul 21, 2024

Copy link
Copy Markdown

GH-122098 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jul 21, 2024
hugovk added a commit that referenced this pull request Jul 21, 2024
[3.13] Merge Ubuntu test matrices in CI (GH-121813) (#122098)
82b8137 
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

hugovk commented Jul 22, 2024

Copy link
Copy Markdown
Member

@webknjaz Please could you do the 3.12 backport? Thanks!

webknjaz added a commit to webknjaz/cpython that referenced this pull request Jul 22, 2024
[3.12] Merge Ubuntu test matrices in CI (pythonGH-121813)
e1254a8 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>.
(cherry picked from commit a3f7db9)

Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>

bedevere-app Bot commented Jul 22, 2024

Copy link
Copy Markdown

GH-122116 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jul 22, 2024

webknjaz commented Jul 22, 2024

Copy link
Copy Markdown
Member Author

@hugovk I've been meaning to do this. Here you go: #122116.

I suppose other PRs may have similar conflicts due to the boundary w/ and w/o free-treading...

webknjaz added a commit to webknjaz/cpython that referenced this pull request Jul 22, 2024
[3.12] Merge Ubuntu test matrices in CI (pythonGH-121813)
1d08251 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>.
(cherry picked from commit a3f7db9)

Co-authored-by: Sviatoslav Sydorenko <webknjaz@redhat.com>
hugovk pushed a commit that referenced this pull request Jul 22, 2024
[3.12] Merge Ubuntu test matrices in CI (GH-121813) (#122116)
8d1f157
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

picnixz picnixz left review comments
hugovk hugovk approved these changes
ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Assignees

hugovk

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL