[3.12] Merge Ubuntu test matrices in CI (GH-121813) - #122116
Conversation
Sorry, something went wrong.
| if: needs.check_source.outputs.run_tests == 'true' | ||
| strategy: | ||
| matrix: | ||
| free-threading: |
There was a problem hiding this comment.
There's no free-threading in 3.12.
The Windows 3.12 backport included free-threading things in reusable-windows.yml but build.yml didn't mention it.
Sorry, something went wrong.
There was a problem hiding this comment.
... because the #121776 backport hasn't been merged yet :)
But that comments out the free-threading: true job. Do the same here?
Sorry, something went wrong.
There was a problem hiding this comment.
But that comments out the free-threading: true job. Do the same here?
Yes! I forgot about that one, only fixed the merge conflicts. I left it commented out to facilitate any future backports, reducing possible conflicts.
Sorry, something went wrong.
There was a problem hiding this comment.
I was wondering why that doesn't fail the CI and saw this:
configure: WARNING: unrecognized options: --disable-gil@hugovk any reason invalid flags don't crash the build process?
Sorry, something went wrong.
There was a problem hiding this comment.
Commented out that matrix factor. Marking this thread as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
I was wondering why that doesn't fail the CI and saw this:
configure: WARNING: unrecognized options: --disable-gil@hugovk any reason invalid flags don't crash the build process?
Let's ask @erlend-aasland
Sorry, something went wrong.
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>. (cherry picked from commit a3f7db9) Co-authored-by: Sviatoslav Sydorenko <webknjaz@redhat.com>
|
Thanks! |
Sorry, something went wrong.
.
(cherry picked from commit a3f7db9)