GH-105879: Note exec/eval keyword change in What's New - #121831
Conversation
Sorry, something went wrong.
Previously, those flags would sometimes end up having empty string
values which tends to break evaluating them as JSON. This patch adds
`false` fallbacks to all such outputs.
This allows feeding them to `fromJSON()` without a fear of them
causing surprising internal behaviors in the GitHub Actions CI/CD
workflows platform itself [[1]]. The behavior observed was that
some skipped jobs wouldn't show up in the workflow sidebar view at
all, would display in the graph view as `Waiting for pending jobs`
and in the `${{ needs }}` context, they would have a
`result: failure` entry.
This should help make PRs like python#121831 mergeable again.
[1]: python#121766 (comment)
Previously, those flags would sometimes end up having empty string
values which tends to break evaluating them as JSON. This patch adds
`false` fallbacks to all such outputs.
This allows feeding them to `fromJSON()` without a fear of them
causing surprising internal behaviors in the GitHub Actions CI/CD
workflows platform itself [[1]]. The behavior observed was that
some skipped jobs wouldn't show up in the workflow sidebar view at
all, would display in the graph view as `Waiting for pending jobs`
and in the `${{ needs }}` context, they would have a
`result: failure` entry [[2]].
This should help make PRs like python#121831 mergeable again.
[1]: python#121766 (comment)
[2]: https://github.com/python/cpython/actions/runs/9950331379/job/27501637459?pr=121831#step:2:244
Previously, those flags would sometimes end up having empty string
values, which tends to break evaluating them as JSON. This patch adds
`false` fallbacks to all such outputs.
This allows feeding them to `fromJSON()` without a fear of them
causing surprising internal behaviors in the GitHub Actions CI/CD
workflows platform itself [[1]]. The behavior observed was that
some skipped jobs wouldn't show up in the workflow sidebar view at
all, would display in the graph view as `Waiting for pending jobs`
and in the `${{ needs }}` context, they would have a
`result: failure` entry [[2]].
This should help make PRs like python#121831 mergeable again.
[1]: python#121766 (comment)
[2]: https://github.com/python/cpython/actions/runs/9950331379/job/27501637459?pr=121831#step:2:244
Previously, those flags would sometimes end up having empty string
values, which tends to break evaluating them as JSON. This patch adds
`false` fallbacks to all such outputs.
This allows feeding them to `fromJSON()` without a fear of them
causing surprising internal behaviors in the GitHub Actions CI/CD
workflows platform itself [[1]]. The behavior observed was that
some skipped jobs wouldn't show up in the workflow sidebar view at
all, would display in the graph view as `Waiting for pending jobs`
and in the `${{ needs }}` context, they would have a
`result: failure` entry [[2]].
This should help make PRs like python#121831 mergeable again.
[1]: python#121766 (comment)
[2]: https://github.com/python/cpython/actions/runs/9950331379/job/27501637459?pr=121831#step:2:244
Previously, those flags would sometimes end up having empty string
values, which tends to break evaluating them as JSON. This patch adds
`false` fallbacks to all such outputs.
This allows feeding them to `fromJSON()` without a fear of them
causing surprising internal behaviors in the GitHub Actions CI/CD
workflows platform itself [[1]]. The behavior observed was that
some skipped jobs wouldn't show up in the workflow sidebar view at
all, would display in the graph view as `Waiting for pending jobs`
and in the `${{ needs }}` context, they would have a
`result: failure` entry [[2]].
This should help make PRs like python#121831 mergeable again.
[1]: python#121766 (comment)
[2]: https://github.com/python/cpython/actions/runs/9950331379/job/27501637459?pr=121831#step:2:244
|
Rebased to check if #121848 fixes the CI. |
Sorry, something went wrong.
|
🤞 |
Sorry, something went wrong.
|
At least the name of the skipped Windows job is still borked. "Tests / Windows ${{ ((fromJSON(matrix.free-threading) && '(free-threading)') || '') }} (pull_requ" |
Sorry, something went wrong.
|
Thanks @ncoghlan for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, something went wrong.
|
GH-121852 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
That's expected. GHA doesn't evaluate skipped matrices, and that would've evaluated to two different names, not one. That's how GHA works. But in general, you don't need to look into those skipped entries as the ones that are of interest to you are prominently marked as red. |
Sorry, something went wrong.
|
@ambv a workaround would be to use a static name: entry and embed the variable bits into the reusable workflow job names one level below. I personally don't really care, but if that annoys you enough, we could go for it. |
Sorry, something went wrong.
|
Though, there might be other limitations with this (some sort of a ${{ '' }} expression, even empty, is usually needed for nicer display in the sidebar when the jobs are actually run). |
Sorry, something went wrong.
|
@ambv if you still want the job names to be rendered differently — let me know, and I can come up with alternative options. |
Sorry, something went wrong.
|
OK, thanks! Let's see how it looks for a while and we'll decide if it's still bothering me later. |
Sorry, something went wrong.
📚 Documentation preview 📚: https://cpython-previews--121831.org.readthedocs.build/