CI: Fix using check_source flags as bool - #121848
Conversation
Sorry, something went wrong.
Previously, those flags would sometimes end up having empty string
values, which tends to break evaluating them as JSON. This patch adds
`false` fallbacks to all such outputs.
This allows feeding them to `fromJSON()` without a fear of them
causing surprising internal behaviors in the GitHub Actions CI/CD
workflows platform itself [[1]]. The behavior observed was that
some skipped jobs wouldn't show up in the workflow sidebar view at
all, would display in the graph view as `Waiting for pending jobs`
and in the `${{ needs }}` context, they would have a
`result: failure` entry [[2]].
This should help make PRs like python#121831 mergeable again.
[1]: python#121766 (comment)
[2]: https://github.com/python/cpython/actions/runs/9950331379/job/27501637459?pr=121831#step:2:244
This updates it to avoid referencing to `no-GIL` in favor of the official term `free-threading`.
hugovk
left a comment
There was a problem hiding this comment.
Thanks!
Sorry, something went wrong.
|
@hugovk this probably needs backport labels too, right? |
Sorry, something went wrong.
|
Yeah, let's test to confirm it works as expected by updating #121831 after this has merged. |
Sorry, something went wrong.
|
Sorry, @webknjaz and @hugovk, I could not cleanly backport this to 3.12 due to a conflict. cherry_picker a0b205bba555dd9c702b9a856cd9a8153277c9b0 3.12 |
Sorry, something went wrong.
(cherry picked from commit a0b205b) Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk@sydorenko.org.ua>
|
GH-121853 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
|
GH-121853 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
(cherry picked from commit a0b205b) Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk@sydorenko.org.ua>
|
GH-121855 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
|
GH-121855 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
|
GH-121855 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk@sydorenko.org.ua>
Previously, those flags would sometimes end up having empty string values, which tends to break evaluating them as JSON. This patch adds false fallbacks to all such outputs.
This allows feeding them to fromJSON() without a fear of them causing surprising internal behaviors in the GitHub Actions CI/CD workflows platform itself [1]. The behavior observed was that some skipped jobs wouldn't show up in the workflow sidebar view at all, would display in the graph view as Waiting for pending jobs and in the ${{ needs }} context, they would have a result: failure entry [2].
This should help make PRs like #121831 mergeable again.