FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-121905: Consistently use "floating-point" instead of "floating point" by serhiy-storchaka · Pull Request #121907 · python/cpython · GitHub

/ cpython Public

gh-121905: Consistently use "floating-point" instead of "floating point" - #121907

Merged
serhiy-storchaka merged 8 commits into
python:mainfrom
serhiy-storchaka:docs-floating-point
Jul 19, 2024
ConversationCommits (8)ChecksFiles changed
Merged

gh-121905: Consistently use "floating-point" instead of "floating point"#121907
serhiy-storchaka merged 8 commits into
python:mainfrom
serhiy-storchaka:docs-floating-point

Conversation

serhiy-storchaka commented Jul 17, 2024 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

serhiy-storchaka added docs Documentation in the Doc dir skip news labels Jul 17, 2024
bedevere-app Bot mentioned this pull request Jul 17, 2024
Closed

serhiy-storchaka commented Jul 17, 2024

Copy link
Copy Markdown
Member Author

I tried to only use "floating-point" for adjectives, like "floating-point number" and "floating-point arithmetic", not for nouns, like "binary floating point" and "decimal floating point", and not change book names, but it needs third party verification. Maybe there are other cases in which the hyphen is not desirable.

erlend-aasland mentioned this pull request Jul 17, 2024
Merged

AlexWaygood commented Jul 17, 2024

Copy link
Copy Markdown
Member

I tried to only use "floating-point" for adjectives, like "floating-point number" and "floating-point arithmetic", not for nouns, like "binary floating point" and "decimal floating point", and not change book names, but it needs third party verification. Maybe there are other cases in which the hyphen is not desirable.

This is the correct distinction; your choices all look correct to me

AA-Turner approved these changes Jul 17, 2024
View reviewed changes

AA-Turner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I've had a brief look through everything and can't spot any obvious problems. I agree re using the hyphenated form.

A

Comment thread Doc/c-api/float.rst
Comment thread Doc/faq/programming.rst Outdated
Comment thread Doc/reference/datamodel.rst
Comment thread Doc/tutorial/floatingpoint.rst
rhettinger removed their request for review July 18, 2024 01:45
mdickinson approved these changes Jul 18, 2024
View reviewed changes

mdickinson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Haven't reviewed line-by-line, but the change LGTM in principle.

serhiy-storchaka added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jul 18, 2024
serhiy-storchaka enabled auto-merge (squash) July 19, 2024 07:42
serhiy-storchaka merged commit 1a0c7b9 into python:main Jul 19, 2024

miss-islington-app Bot commented Jul 19, 2024

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington-app Bot commented Jul 19, 2024

Copy link
Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 1a0c7b9ba48a2dffb70bb0c7327abae1d3e87356 3.13

miss-islington-app Bot commented Jul 19, 2024

Copy link
Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 1a0c7b9ba48a2dffb70bb0c7327abae1d3e87356 3.12

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jul 19, 2024
[3.13] pythongh-121905: Consistently use "floating-point" instead of …
d513ade 
…"floating point" (pythonGH-121907)

(cherry picked from commit 1a0c7b9)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

bedevere-app Bot commented Jul 19, 2024

Copy link
Copy Markdown

GH-122012 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jul 19, 2024
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jul 19, 2024
pythongh-121905: Consistently use "floating-point" instead of "floati…
31868ad 
…ng point" (pythonGH-121907)

(cherry picked from commit 1a0c7b9)

bedevere-app Bot commented Jul 19, 2024

Copy link
Copy Markdown

GH-122013 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jul 19, 2024
serhiy-storchaka added a commit that referenced this pull request Jul 19, 2024
[3.12] gh-121905: Consistently use "floating-point" instead of "float…
39dea21 
…ing point" (GH-121907) (GH-122013)

(cherry picked from commit 1a0c7b9)
serhiy-storchaka added a commit that referenced this pull request Jul 19, 2024
[3.13] gh-121905: Consistently use "floating-point" instead of "float…
a45d905 
…ing point" (GH-121907) (GH-122012)

(cherry picked from commit 1a0c7b9)
serhiy-storchaka deleted the docs-floating-point branch July 19, 2024 13:10
serhiy-storchaka removed their assignment Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AA-Turner AA-Turner approved these changes
ezio-melotti ezio-melotti left review comments
AlexWaygood AlexWaygood approved these changes
pablogsal Awaiting requested review from pablogsal pablogsal is a code owner
lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner
pganssle Awaiting requested review from pganssle pganssle is a code owner
abalkin Awaiting requested review from abalkin
iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner
erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
corona10 Awaiting requested review from corona10 corona10 is a code owner
+1 more reviewer
mdickinson mdickinson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL