FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Clarify 'time zone' in a Specific words section by nedbat · Pull Request #1352 · python/devguide · GitHub

Clarify 'time zone' in a Specific words section - #1352

Merged
nedbat merged 3 commits into
python:mainfrom
nedbat:nedbat/glossary
Jul 18, 2024
Merged

Clarify 'time zone' in a Specific words section#1352
nedbat merged 3 commits into
python:mainfrom
nedbat:nedbat/glossary

Conversation

nedbat commented Jul 15, 2024
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

python/cpython#118449 corrects "timezone" to "time zone". This records the guidance for posterity.


📚 Documentation preview 📚: https://cpython-devguide--1352.org.readthedocs.build/

AA-Turner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We could perhaps use a .. glossary:: directive here?

A

Comment thread documentation/style-guide.rst Outdated
Comment on lines +89 to +90
Only spell as one word when referring to a Python term like a module,
class, or argument.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Shouldn't they have markup like :mod: or similar in this case?
If that's the case, "timezone" should never appear in plain text.
Not sure if it's worth clarifying this.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Not sure if it's worth clarifying this.

Anyone reading the devguide style guide will probably already know how to mark up classes, so I'm not sure it's worth complicating the current wording.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

What I meant is:

  • talking about the concept? Always use two words and no markup.
  • talking about the module/class/arg? Always use one word and the appropriate markup.

This implies that "timezone" will never appear in plain text and "time zone" will never appear within markup.

IOW, the fact that you are using markup or not already determines whether to use one or two words, without having to think if you are referring to a module/class/argument or not.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sure, if it does not clutter the wording too much, I'm fine with such a change.

nedbat commented Jul 16, 2024

Copy link
Copy Markdown
Member Author

We could perhaps use a .. glossary:: directive here?

I'm not sure this rises to that level yet, but will keep it in mind.

Comment thread documentation/style-guide.rst Outdated
Comment on lines +60 to +63
.. _glossary:

Specific words
==============

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I predict this will confuse me, shall we have the same name for both the link and the title?

ezio-melotti Jul 16, 2024
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The link might also be confused with the glossary directive.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I changed the reference to specific words.

Copy link
Copy Markdown
Contributor

Related:

Comment thread documentation/style-guide.rst Outdated
Comment on lines +88 to +90
Spell out as two words when talking about the real-world concept.
Only spell as one word when referring to a Python term like a module,
class, or argument.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
Spell out as two words when talking about the real-world concept.
Only spell as one word when referring to a Python term like a module,
class, or argument.
When referring to a Python term like a module, class, or argument
it is always spelled as one word and surrounded by the appropriate markup
(for example, ``:mod:`timezone```).
When talking about the real-world concept it is spelled as two words.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I added a modified version of this text.

nedbat merged commit c3950af into python:main Jul 18, 2024
nedbat deleted the nedbat/glossary branch July 18, 2024 17:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL