FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-122237: Fix REPL wrong auto-indentation with comments by HarryLHW · Pull Request #122238 · python/cpython · GitHub

Repository navigation

gh-122237: Fix REPL wrong auto-indentation with comments - #122238

Closed
HarryLHW wants to merge 1 commit into
python:mainfrom
HarryLHW:repl-autoindent
Closed

HarryLHW wants to merge 1 commit into
python:mainfrom
HarryLHW:repl-autoindent

Conversation

HarryLHW commented Jul 24, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown
Contributor Author

At this point, it will never auto-indent if there is only a comment without other code in the last line. This will produce the following situation, and I am trying to fix that if possible.

Copy link
Copy Markdown
Contributor

At this point, it will never auto-indent if there is only a comment without other code in the last line. This will produce the following situation, and I am trying to fix that if possible.

For what it’s worth, I’m not sure I would consider this a bug. Presumably, the user had to un-indent the comment line deliberately, so I would expect the following line to also be un-indented, if that makes sense.

Are there other situations where this behavior leads to incorrect indentation?

ambv commented Oct 23, 2024

Copy link
Copy Markdown
Contributor

This is fixed already.

ambv closed this Oct 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL