FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-122237: Fix repl auto indentation wrong with comments by AnsonTrapani · Pull Request #122383 · python/cpython · GitHub

Repository navigation

gh-122237: Fix repl auto indentation wrong with comments - #122383

Closed
AnsonTrapani wants to merge 5 commits into
python:mainfrom
AnsonTrapani:fix-repl-auto-indentation-wrong-with-comments
Closed

AnsonTrapani wants to merge 5 commits into
python:mainfrom
AnsonTrapani:fix-repl-auto-indentation-wrong-with-comments

Conversation

AnsonTrapani commented Jul 29, 2024 •
edited by Eclips4
Loading

Copy link
Copy Markdown

ghost commented Jul 29, 2024 •
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

bedevere-app Bot commented Jul 29, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Eclips4 changed the title Fix repl auto indentation wrong with comments: gh-122237 gh-122237: Fix repl auto indentation wrong with comments Jul 29, 2024

bedevere-app Bot commented Jul 29, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Copy link
Copy Markdown
Member

There's also a proposed fix in #122238.

Copy link
Copy Markdown
Author

There's also a proposed fix in #122238.

Hi devdanzin,

Does that one get the priority then or is this merge request going to be closed without a merge? Sorry, this is my first time contributing here so I'm not sure of the procedure!

Thank you!

Copy link
Copy Markdown
Member

If two PRs have different solutions, 'priority' is not an issue. (I have not looked at either.) A core dev needs to decide which is superior and merge that, possibly after further changes. Reviewers can test both and give opinions.

ambv commented Oct 23, 2024

Copy link
Copy Markdown
Contributor

Fixed in GH-123196.

ambv closed this Oct 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL