[3.13] Further revise idlelib/Icons/README.text (GH-123364) - #123608
Merged
Yhg1s merged 2 commits intoSep 24, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
In particular, add trademark derivative approval information. (cherry picked from commit fe85a82) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
vstinner
reviewed
Sep 3, 2024
Comment thread
Lib/idlelib/Icons/README.txt
| https://github.com/python/cpython/issues/64605 | ||
| .gif versions were also added. | ||
|
|
||
| 2020: Add Clover's 256-bit image. |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
256 pixels, not 256-bit
Sorry, something went wrong.
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
cc @terryjreedy
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
All 'bits' should be 'pixels'. I will make a new PR for main and backport. |
Sorry, something went wrong.
terryjreedy
reviewed
Sep 23, 2024
Comment thread
Lib/idlelib/Icons/README.txt
Outdated
terryjreedy
added a commit
to terryjreedy/cpython
that referenced
this pull request
Sep 23, 2024
See python#123597. The typo in Icon/README.txt was fixed in the unmerged 3.13 backport python#123608 of the PR that added the text with the typo. (cherry picked from commit 1f4a49e) Co-authored-by: abstractee
terryjreedy
approved these changes
Sep 23, 2024
terryjreedy
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Typo fix from another PR is included.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In particular, add trademark derivative approval information.
(cherry picked from commit fe85a82)
Co-authored-by: Terry Jan Reedy tjreedy@udel.edu