FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix typos in warnings, docstrings, comments and text files by abstractee · Pull Request #123597 · python/cpython · GitHub

/ cpython Public

Fix typos in warnings, docstrings, comments and text files - #123597

Merged
vstinner merged 2 commits into
python:mainfrom
abstractee:fixed-typos
Sep 3, 2024
ConversationCommits (2)ChecksFiles changed
Merged

Fix typos in warnings, docstrings, comments and text files#123597
vstinner merged 2 commits into
python:mainfrom
abstractee:fixed-typos

Conversation

abstractee commented Sep 2, 2024

Copy link
Copy Markdown
Contributor

This corrects some typos in comments, docstrings and text files.

ghost commented Sep 2, 2024 •
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

bedevere-app Bot commented Sep 2, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Wulian233 commented Sep 2, 2024

Copy link
Copy Markdown
Contributor

Do not modify the idle help.html, as it is automatically generated and the typo was fixed 4 months ago.
e7ba6e9

"referencable" and "referenceable" are both acceptable spellings. Let's just leave this file as it is. https://en.wiktionary.org/wiki/referencable
#123201 (comment)

Wulian233 suggested changes Sep 2, 2024
View reviewed changes
Comment thread Include/refcount.h Outdated
* For example, if `op` points to a Python integer, you know that destroying
* one of those can't cause problems -- but in part that relies on that
* Python integers aren't currently weakly referencable. Best practice is
* Python integers aren't currently weakly referenceable. Best practice is

Wulian233 Sep 2, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
* Python integers aren't currently weakly referenceable. Best practice is
* Python integers aren't currently weakly referencable. Best practice is

abstractee Sep 2, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for the feedback. Corrected.

nineteendo Sep 2, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Aren't both of these changes correct?

Comment thread Lib/idlelib/help.html Outdated
code interactively. IDLE’s Shell window also responds to the following:</p>
<ul class="simple">
<li><p><kbd class="kbd compound docutils literal notranslate"><kbd class="kbd docutils literal notranslate">C</kbd>-<kbd class="kbd docutils literal notranslate">c</kbd></kbd> attemps to interrupt statement execution (but may fail).</p></li>
<li><p><kbd class="kbd compound docutils literal notranslate"><kbd class="kbd docutils literal notranslate">C</kbd>-<kbd class="kbd docutils literal notranslate">c</kbd></kbd> attempts to interrupt statement execution (but may fail).</p></li>

Wulian233 Sep 2, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
<li><p><kbd class="kbd compound docutils literal notranslate"><kbd class="kbd docutils literal notranslate">C</kbd>-<kbd class="kbd docutils literal notranslate">c</kbd></kbd> attempts to interrupt statement execution (but may fail).</p></li>
<li><p><kbd class="kbd compound docutils literal notranslate"><kbd class="kbd docutils literal notranslate">C</kbd>-<kbd class="kbd docutils literal notranslate">c</kbd></kbd> attemps to interrupt statement execution (but may fail).</p></li>

abstractee Sep 2, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Removed the file from the commit. Thank you.

picnixz reviewed Sep 2, 2024
View reviewed changes
Comment thread Lib/_pyio.py Outdated
This class provides dummy implementations for many methods that
derived classes can override selectively; the default implementations
represent a file that cannot be read, written or seeked.
represent a file that cannot be read, written or sought.

picnixz Sep 2, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

While I understand this change, I think we can use seeked here. One existing wording is https://developer.mozilla.org/en-US/docs/Web/API/HTMLMediaElement/seeked_event which relates to seek operations.

jaraco added a commit to python/importlib_resources that referenced this pull request Sep 2, 2024
Fix typo in _temp_path comment.
d84ca37 
Ref python/cpython#123597
jaraco approved these changes Sep 2, 2024
View reviewed changes

jaraco left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM (importlib/resources/_common.py).

hugovk changed the title Fix typos in comments Fix typos in warnings, docstrings, comments and text files Sep 2, 2024
vstinner merged commit 1f4a49e into python:main Sep 3, 2024

vstinner commented Sep 3, 2024

Copy link
Copy Markdown
Member

Merged, thanks. I don't think that it's worth it to backport the change.

terryjreedy commented Sep 3, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

I want idlelib changes backported. Since _strptime change will not backport to 3.12, will do new PR after 3.13.0.

abstractee deleted the fixed-typos branch September 3, 2024 09:12
jaraco added a commit to python/importlib_resources that referenced this pull request Sep 12, 2024
Fix typo in _temp_path comment.
a25f00e 
Ref python/cpython#123597
terryjreedy added a commit to terryjreedy/cpython that referenced this pull request Sep 23, 2024
[3.12] Backport idlelib typos
89cfda3 
See python#123597.

(cherry picked from commit 1f4a49e)

Co-authored-by: abstractee
terryjreedy mentioned this pull request Sep 23, 2024
Merged
terryjreedy added a commit to terryjreedy/cpython that referenced this pull request Sep 23, 2024
[3.13] Backport idlelib typos
9950942 
See python#123597.  The typo in Icon/README.txt was fixed
in the unmerged 3.13 backport python#123608 of the
PR that added the text with the typo.

(cherry picked from commit 1f4a49e)

Co-authored-by: abstractee
terryjreedy mentioned this pull request Sep 23, 2024
Merged
terryjreedy added a commit that referenced this pull request Sep 23, 2024
[3.12] Backport idlelib typos (#124324)
7d505fe 
See #123597.

(cherry picked from commit 1f4a49e)

Co-authored-by: abstractee
Yhg1s pushed a commit that referenced this pull request Sep 27, 2024
[3.13] Backport idlelib typos (#124325)
2df77c8 
See #123597.  The typo in Icon/README.txt was fixed
in the unmerged 3.13 backport #123608 of the
PR that added the text with the typo.

(cherry picked from commit 1f4a49e)

Co-authored-by: abstractee
zetaloop pushed a commit to zetaloop/IDLE-CN-base that referenced this pull request Nov 4, 2024
[3.12] Backport idlelib typos (#124324)
6e22283 
See python/cpython#123597.

(cherry picked from commit 1f4a49e)

Co-authored-by: abstractee
zetaloop pushed a commit to zetaloop/IDLE-CN-base that referenced this pull request Jan 13, 2025
[3.12] Backport idlelib typos (#124324)
b9dbfeb 
See python/cpython#123597.

(cherry picked from commit 504f724)

Co-authored-by: abstractee

corneliusroemer commented Jul 19, 2025

Copy link
Copy Markdown
Contributor

I'm getting the "ambiguious" typo in Python 3.13 - might be worth backporting as a bugfix.

Just checking for "year specified is ambiguious and" on Github shows lots of exact matches: https://github.com/search?q=%22year+specified+is+ambiguious%22&type=code

zetaloop pushed a commit to zetaloop/IDLE-CN-base that referenced this pull request Oct 3, 2025
[3.12] Backport idlelib typos (#124324)
39b03d2 
See python/cpython#123597.

(cherry picked from commit 1f4a49e)

Co-authored-by: abstractee
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

picnixz picnixz left review comments
jaraco jaraco approved these changes
terryjreedy Awaiting requested review from terryjreedy terryjreedy is a code owner
pganssle Awaiting requested review from pganssle pganssle is a code owner
abalkin Awaiting requested review from abalkin
warsaw Awaiting requested review from warsaw warsaw is a code owner
FFY00 Awaiting requested review from FFY00 FFY00 is a code owner
brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
gpshead Awaiting requested review from gpshead gpshead is a code owner
tiran Awaiting requested review from tiran
+2 more reviewers
nineteendo nineteendo left review comments
Wulian233 Wulian233 requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL