FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-102511: Change the `os.path.splitroot` param name from `path` back to `p` by sobolevn · Pull Request #124097 · python/cpython · GitHub

/ cpython Public

gh-102511: Change the os.path.splitroot param name from path back to p - #124097

Merged
zooba merged 1 commit into
python:mainfrom
sobolevn:issue-102511-param-name
Sep 18, 2024
ConversationCommits (1)ChecksFiles changed
Merged

gh-102511: Change the os.path.splitroot param name from path back to p#124097
zooba merged 1 commit into
python:mainfrom
sobolevn:issue-102511-param-name

Conversation

sobolevn commented Sep 15, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Refs #118089

CC @nineteendo

Now it is in sync with the Python version here:

bedevere-app Bot mentioned this pull request Sep 15, 2024
Closed
sobolevn added skip news needs backport to 3.13 bugs and security fixes labels Sep 15, 2024

nineteendo commented Sep 15, 2024

Copy link
Copy Markdown
Contributor

Thanks, I didn't notice this. I was too focused on the difficult aspects of the PR.

zooba merged commit 3b6bfa7 into python:main Sep 18, 2024

miss-islington-app Bot commented Sep 18, 2024

Copy link
Copy Markdown

Thanks @sobolevn for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington-app Bot commented Sep 18, 2024

Copy link
Copy Markdown

Sorry, @sobolevn and @zooba, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 3b6bfa77aa4da2ce1f3a15e39831f8b85882698c 3.13

zooba commented Sep 18, 2024

Copy link
Copy Markdown
Member

Backport should wait for 3.13.1 anyway, so we'll rebase it then.

zware mentioned this pull request Sep 18, 2024
Merged
savannahostrowski pushed a commit to savannahostrowski/cpython that referenced this pull request Sep 22, 2024
pythongh-102511: Change the os.path.splitroot param name from `path…
3c9475b 
…` back to `p` (pythonGH-124097)

bedevere-app Bot commented Oct 3, 2024

Copy link
Copy Markdown

GH-124919 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Oct 3, 2024
JelleZijlstra pushed a commit to JelleZijlstra/cpython that referenced this pull request Oct 3, 2024
[3.13] pythongh-102511: Change the os.path.splitroot param name fro…
8a0285b 
…m `path` back to `p` (pythonGH-124097)

(cherry picked from commit 3b6bfa7)

Co-authored-by: sobolevn <mail@sobolevn.me>

JelleZijlstra commented Oct 3, 2024

Copy link
Copy Markdown
Member

I opened the backport PR just so this doesn't get lost, the conflict was in clinic output only.

JelleZijlstra added a commit that referenced this pull request Oct 8, 2024
[3.13] gh-102511: Change the os.path.splitroot param name from `pat…
761c3b2 
…h` back to `p` (GH-124097) (#124919)

(cherry picked from commit 3b6bfa7)

Co-authored-by: sobolevn <mail@sobolevn.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

picnixz picnixz approved these changes
barneygale Awaiting requested review from barneygale
hugovk Awaiting requested review from hugovk
zooba Awaiting requested review from zooba

Assignees

zooba

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL