FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-116622: Complete Android documentation by mhsmith · Pull Request #124259 · python/cpython · GitHub

/ cpython Public

gh-116622: Complete Android documentation - #124259

Merged
AA-Turner merged 15 commits into
python:mainfrom
mhsmith:android-docs
Sep 23, 2024
ConversationCommits (15)ChecksFiles changed
Merged

gh-116622: Complete Android documentation#124259
AA-Turner merged 15 commits into
python:mainfrom
mhsmith:android-docs

Conversation

mhsmith commented Sep 20, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

The Android x86_64 buildbot is not yet up and running, so the statement that "Android is now a PEP 11 supported platform" is not quite ready to be merged, but I'd like to get an early review.

Summary:

  • Add an Android page to the "Setup and Usage" section.
  • Generalize the "Notes on availability" section to cover both iOS and Android.
  • Add "availability" markers to the modules and functions not supported on Android.

📚 Documentation preview 📚: https://cpython-previews--124259.org.readthedocs.build/

bedevere-app Bot mentioned this pull request Sep 20, 2024
Closed
mhsmith added the needs backport to 3.13 bugs and security fixes label Sep 20, 2024
mhsmith mentioned this pull request Sep 20, 2024
Merged
6 tasks
freakboy3742 approved these changes Sep 20, 2024
View reviewed changes

freakboy3742 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This all looks good to me from a technical perspective; I'd like someone with more of a documentation eye (@hugovk?) to weigh in on any of the markup and layout aspects.

serhiy-storchaka approved these changes Sep 22, 2024
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I am not expert in Android, WASM or iOS, but this LGTM.

Comment thread Doc/using/android.rst Outdated
Comment thread Doc/using/android.rst

* `Briefcase <https://briefcase.readthedocs.io>`__, from the BeeWare project
* `Buildozer <https://buildozer.readthedocs.io>`__, from the Kivy project
* `Chaquopy <https://chaquo.com/chaquopy>`__

serhiy-storchaka Sep 22, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

You are affiliated with this, right? I do not think there is a problem here, taking into account open-sourcing Chaquopy and your contribution in CPython.

freakboy3742 Sep 23, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Correct - Malcolm is the founder of Chaquopy.

mhsmith Sep 23, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I've expanded this list to include all the production-quality Python-on-Android tools that I'm aware of.

Comment thread Doc/whatsnew/3.13.rst
AA-Turner reviewed Sep 23, 2024
View reviewed changes

AA-Turner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Two quick comments:

Comment thread Doc/whatsnew/3.13.rst
Comment thread Doc/whatsnew/3.13.rst
AA-Turner requested review from AA-Turner and removed request for corona10, erlend-aasland and pradyunsg September 23, 2024 15:13
freakboy3742 reviewed Sep 23, 2024
View reviewed changes
Comment thread Doc/whatsnew/3.13.rst
freakboy3742 reviewed Sep 23, 2024
View reviewed changes
Comment thread Doc/using/android.rst Outdated
freakboy3742 reviewed Sep 23, 2024
View reviewed changes
Comment thread Doc/whatsnew/3.13.rst Outdated

Yhg1s commented Sep 23, 2024

Copy link
Copy Markdown
Member

Russel mentioned the android buildbot is now all set up and working, so is this ready to go in? :)

freakboy3742 commented Sep 23, 2024

Copy link
Copy Markdown
Contributor

@Yhg1s 2 Android buildbots are up and running:

The failures on the arm64 buildbot occur inconsistently; they would be been addressed by #123988, #124034, and #124035. Those 3 PRs alter the test suite and the Android test runner to make test conditions reproducible.

AA-Turner reviewed Sep 23, 2024
View reviewed changes
Comment thread Android/README.md Outdated
Comment thread Android/README.md Outdated
Comment thread Android/README.md Outdated
Comment thread Doc/includes/wasm-mobile-notavail.rst Outdated
Comment thread Doc/library/dbm.rst
Comment thread Doc/library/intro.rst
Comment thread Doc/using/android.rst Outdated
Comment thread Doc/using/android.rst Outdated
Comment thread Doc/using/android.rst Outdated
Comment thread Doc/whatsnew/3.13.rst
AA-Turner enabled auto-merge (squash) September 23, 2024 22:55
AA-Turner added the docs Documentation in the Doc dir label Sep 23, 2024
AA-Turner merged commit e80dd30 into python:main Sep 23, 2024

miss-islington-app Bot commented Sep 23, 2024

Copy link
Copy Markdown

Thanks @mhsmith for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 23, 2024
pythongh-116622: Complete Android documentation (pythonGH-124259)
4a3b708 
(cherry picked from commit e80dd30)

Co-authored-by: Malcolm Smith <smith@chaquo.com>
Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
Co-authored-by: T. Wouters <thomas@python.org>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

bedevere-app Bot commented Sep 23, 2024

Copy link
Copy Markdown

GH-124395 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Sep 23, 2024
Yhg1s added a commit that referenced this pull request Sep 24, 2024
[3.13] gh-116622: Complete Android documentation (GH-124259) (#124395)
9a60a9d 
gh-116622: Complete Android documentation (GH-124259)
(cherry picked from commit e80dd30)

Co-authored-by: Malcolm Smith <smith@chaquo.com>
Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
Co-authored-by: T. Wouters <thomas@python.org>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

freakboy3742 freakboy3742 approved these changes
serhiy-storchaka serhiy-storchaka approved these changes
AA-Turner AA-Turner approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL