FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

PEP 738: Mark as Final by mhsmith · Pull Request #3982 · python/peps · GitHub

/ peps Public

PEP 738: Mark as Final - #3982

Merged
AA-Turner merged 6 commits into
python:mainfrom
mhsmith:android-final
Oct 7, 2024
ConversationCommits (6)ChecksFiles changed
Merged

PEP 738: Mark as Final#3982
AA-Turner merged 6 commits into
python:mainfrom
mhsmith:android-final

Conversation

mhsmith commented Sep 20, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

The Android x86_64 buildbot is not yet up and running, so this is not quite ready to be merged. The aarch64 and x86_64 buildbots are both now stable.

@freakboy3742: I assume you're OK with being added as a second core team contact for Android?

📚 Documentation preview 📚: https://pep-previews--3982.org.readthedocs.build/

freakboy3742 reviewed Sep 20, 2024
View reviewed changes

freakboy3742 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Confirming that yes - I'm OK being added as a contact for Android platform support.

One other comment inline.

Comment thread peps/pep-0738.rst
CAM-Gerlach reviewed Sep 20, 2024
View reviewed changes

CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for being thorough here! There is a small changed needed to fix the intersphinx links to the canonical doc; it should be straightforward but I can commit it for you if you like.

Comment thread peps/pep-0738.rst Outdated
mhsmith changed the title PEP 738: Mark Final, and add Android to PEP 11 PEP 738: Mark Final Sep 23, 2024
mhsmith mentioned this pull request Sep 23, 2024
Merged
4 tasks
freakboy3742 mentioned this pull request Oct 1, 2024
Closed
AA-Turner changed the title PEP 738: Mark Final PEP 738: Mark as Final Oct 1, 2024

AA-Turner commented Oct 1, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

@mhsmith is there anything outstanding on this PR? [Edit: waiting for 3.13.0 final release for the using-android target to work]

A

hugovk reviewed Oct 1, 2024
View reviewed changes
Comment thread peps/pep-0738.rst

mhsmith commented Oct 1, 2024

Copy link
Copy Markdown
Member Author

@AA-Turner changed the title PEP 738: Mark Final PEP 738: Mark as Final

You might want to update the title instructions in the PR template.

willingc approved these changes Oct 2, 2024
View reviewed changes

willingc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks @mhsmith. Do you want to take this PR out of draft mode?

mhsmith marked this pull request as ready for review October 2, 2024 21:09
mhsmith requested a review from encukou as a code owner October 2, 2024 21:09

hugovk commented Oct 7, 2024

Copy link
Copy Markdown
Member

3.13.0 final is out! https://discuss.python.org/t/python-3-13-0-final-has-been-released/66972

https://docs.python.org/3/ is now 3.13!

I've restarted the CI but it says:

/home/runner/work/peps/peps/peps/pep-0738.rst:12: WARNING: undefined label: 'python:using-android' [ref.ref]

AA-Turner commented Oct 7, 2024

Copy link
Copy Markdown
Member

I purged https://docs.python.org/3/objects.inv and re-ran again but still failing...

The targets are there in objects.inv, though:

python -m sphinx.ext.intersphinx https://docs.python.org/3/objects.inv | rg android
py:attribute
    test.support.is_android                                                          : library/test.html#test.support.is_android
py:function
    platform.android_ver                                                             : library/platform.html#platform.android_ver
    sys.getandroidapilevel                                                           : library/sys.html#sys.getandroidapilevel
std:doc
    using/android                            Using Python on Android                 : using/android.html
std:label
    using-android                            Using Python on Android                 : using/android.html#using-android

AA-Turner merged commit dbb5594 into python:main Oct 7, 2024
hugovk mentioned this pull request Oct 7, 2024
Closed
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

freakboy3742 freakboy3742 left review comments
hugovk hugovk left review comments
AA-Turner AA-Turner left review comments
CAM-Gerlach CAM-Gerlach left review comments
willingc willingc approved these changes
encukou Awaiting requested review from encukou encukou is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for Android as a target platform

6 participants

Back | FazBrowse Home | New Git URL