FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-124872: Change PyContext_WatchCallback to take PyObject by rhansen · Pull Request #124737 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-124872: Change PyContext_WatchCallback to take PyObject - #124737

Merged
1st1 merged 1 commit into
python:mainfrom
rhansen:gh-119333-context-watch
Oct 12, 2024
ConversationCommits (1)ChecksFiles changed
Merged

gh-124872: Change PyContext_WatchCallback to take PyObject#124737
1st1 merged 1 commit into
python:mainfrom
rhansen:gh-119333-context-watch

Conversation

rhansen commented Sep 28, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

The PyContext struct is not intended to be public, and users of the API don't need anything more specific than PyObject. Also see gh-78943.

I don't think a NEWS blurb is needed because this amends a feature that is new to v3.14 so the existing blurb should suffice.

cc @fried

📚 Documentation preview 📚: https://cpython-previews--124737.org.readthedocs.build/

rhansen requested a review from 1st1 as a code owner September 28, 2024 22:17

bedevere-app Bot commented Sep 28, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bedevere-app Bot mentioned this pull request Sep 28, 2024
Closed
rhansen force-pushed the gh-119333-context-watch branch from 84c233e to 37dae27 Compare September 28, 2024 22:25

bedevere-app Bot commented Sep 28, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

rhansen mentioned this pull request Sep 30, 2024
Merged
rhansen force-pushed the gh-119333-context-watch branch from 37dae27 to ac65639 Compare October 1, 2024 23:23

bedevere-app Bot commented Oct 1, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

rhansen changed the title gh-119333: Change PyContext_WatchCallback to take PyObject gh-124872: Change PyContext_WatchCallback to take PyObject Oct 1, 2024
bedevere-app Bot mentioned this pull request Oct 1, 2024
Open
rhansen force-pushed the gh-119333-context-watch branch from ac65639 to 7681358 Compare October 10, 2024 08:45
1st1 added the skip news label Oct 12, 2024

1st1 commented Oct 12, 2024

Copy link
Copy Markdown
Member

@rhansen please rebase

pythongh-124872: Change PyContext_WatchCallback to take PyObject
79df721 
The PyContext struct is not intended to be public, and users of the
API don't need anything more specific than PyObject.  Also see
pythongh-78943.
rhansen force-pushed the gh-119333-context-watch branch from 7681358 to 79df721 Compare October 12, 2024 20:28
1st1 approved these changes Oct 12, 2024
View reviewed changes

1st1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Good refactoring and jives well with the idea that C API should expose (PyObject*) for objects and not their concrete structs.

1st1 merged commit 330c527 into python:main Oct 12, 2024
rhansen deleted the gh-119333-context-watch branch October 12, 2024 21:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1st1 1st1 approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL