FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-116510: Fix a Crash Due to Shared Immortal Interned Strings by ericsnowcurrently · Pull Request #124865 · python/cpython · GitHub

/ cpython Public

gh-116510: Fix a Crash Due to Shared Immortal Interned Strings - #124865

Merged
ericsnowcurrently merged 3 commits into
python:mainfrom
ericsnowcurrently:fix-tracerefs
Oct 9, 2024
ConversationCommits (3)ChecksFiles changed
Merged

gh-116510: Fix a Crash Due to Shared Immortal Interned Strings#124865
ericsnowcurrently merged 3 commits into
python:mainfrom
ericsnowcurrently:fix-tracerefs

Conversation

ericsnowcurrently commented Oct 1, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Fix a crash caused by immortal interned strings being shared between
sub-interpreters that use basic single-phase init. In that case, the string
can be used by an interpreter that outlives the interpreter that created and
interned it. For interpreters that share obmalloc state, also share the
interned dict with the main interpreter.

This is an un-revert of gh-124646 that addresses the Py_TRACE_REFS failures identified by gh-124785.

The 3.12 backport will be slightly different and will need to be done manually.

ericsnowcurrently added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Oct 1, 2024
bedevere-app Bot mentioned this pull request Oct 1, 2024
Closed
ericsnowcurrently mentioned this pull request Oct 1, 2024
Closed

ericsnowcurrently commented Oct 1, 2024

Copy link
Copy Markdown
Member Author

!buildbot AMD64 Arch Linux TraceRefs

bedevere-bot commented Oct 1, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 623fb87 🤖

The command will test the builders whose names match following regular expression: AMD64 Arch Linux TraceRefs

The builders matched are:

  • AMD64 Arch Linux TraceRefs PR

nascheme mentioned this pull request Oct 1, 2024
Closed
nascheme reviewed Oct 1, 2024
View reviewed changes
Comment thread Objects/object.c

#ifdef Py_TRACE_REFS
void
_Py_NormalizeImmortalReference(PyObject *op)

nascheme Oct 1, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Having some comment here would be helpful. Otherwise this function looks quite mysterious.

ericsnowcurrently Oct 1, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

done!

nascheme commented Oct 1, 2024

Copy link
Copy Markdown
Member

LGTM other than adding a bit more comments.

ericsnowcurrently commented Oct 1, 2024

Copy link
Copy Markdown
Member Author

The buildbot passed.

nascheme commented Oct 8, 2024

Copy link
Copy Markdown
Member

Any reason not to merge this now?

ericsnowcurrently commented Oct 8, 2024

Copy link
Copy Markdown
Member Author

I can merge it first thing tomorrow if no one objects.

ericsnowcurrently merged commit f2cb399 into python:main Oct 9, 2024

miss-islington-app Bot commented Oct 9, 2024

Copy link
Copy Markdown

Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

ericsnowcurrently deleted the fix-tracerefs branch October 9, 2024 17:32
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 9, 2024
pythongh-116510: Fix a Crash Due to Shared Immortal Interned Strings (p…
a5b6574 
…ythongh-124865)

Fix a crash caused by immortal interned strings being shared between
sub-interpreters that use basic single-phase init. In that case, the string
can be used by an interpreter that outlives the interpreter that created and
interned it. For interpreters that share obmalloc state, also share the
interned dict with the main interpreter.

This is an un-revert of pythongh-124646 that then addresses the Py_TRACE_REFS
failures identified by pythongh-124785.
(cherry picked from commit f2cb399)

Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 9, 2024
pythongh-116510: Fix a Crash Due to Shared Immortal Interned Strings (p…
762cb25 
…ythongh-124865)

Fix a crash caused by immortal interned strings being shared between
sub-interpreters that use basic single-phase init. In that case, the string
can be used by an interpreter that outlives the interpreter that created and
interned it. For interpreters that share obmalloc state, also share the
interned dict with the main interpreter.

This is an un-revert of pythongh-124646 that then addresses the Py_TRACE_REFS
failures identified by pythongh-124785.
(cherry picked from commit f2cb399)

Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>

bedevere-app Bot commented Oct 9, 2024

Copy link
Copy Markdown

GH-125204 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Oct 9, 2024

bedevere-app Bot commented Oct 9, 2024

Copy link
Copy Markdown

GH-125205 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Oct 9, 2024

encukou commented Oct 10, 2024

Copy link
Copy Markdown
Member

Due to either this change or #125199, the AMD64 Arch Linux TraceRefs 3.x buildbot is failing: https://buildbot.python.org/#/builders/484/builds/6022/steps/6/logs/stdio

encukou mentioned this pull request Oct 10, 2024
Merged

vstinner commented Oct 10, 2024

Copy link
Copy Markdown
Member

Due to either this change or #124865, the AMD64 Arch Linux TraceRefs 3.x buildbot is failing: https://buildbot.python.org/#/builders/484/builds/6022/steps/6/logs/stdio

I checked with git bisect and the regression was introduced by commit f2cb399:

commit f2cb39947093feda3ff85b8dc820922cc5e5f954
Author: Eric Snow <ericsnowcurrently@gmail.com>
Date:   Wed Oct 9 11:32:16 2024 -0600

    gh-116510: Fix a Crash Due to Shared Immortal Interned Strings (gh-124865)
    
    Fix a crash caused by immortal interned strings being shared between
    sub-interpreters that use basic single-phase init. In that case, the string
    can be used by an interpreter that outlives the interpreter that created and
    interned it. For interpreters that share obmalloc state, also share the
    interned dict with the main interpreter.
    
    This is an un-revert of gh-124646 that then addresses the Py_TRACE_REFS
    failures identified by gh-124785.

This was referenced Oct 10, 2024
Merged
Merged

ericsnowcurrently commented Oct 10, 2024

Copy link
Copy Markdown
Member Author

I'll take a look.

This was referenced Oct 10, 2024
Closed
Closed
encukou pushed a commit that referenced this pull request Nov 12, 2024
[3.13] gh-116510: Fix a Crash Due to Shared Immortal Interned Strings (…
02cd3ce 
…gh-124865) (gh-125709) (GH-125204)

* gh-116510: Fix a Crash Due to Shared Immortal Interned Strings (gh-124865)

Fix a crash caused by immortal interned strings being shared between
sub-interpreters that use basic single-phase init. In that case, the string
can be used by an interpreter that outlives the interpreter that created and
interned it. For interpreters that share obmalloc state, also share the
interned dict with the main interpreter.

This is an un-revert of gh-124646 that then addresses the Py_TRACE_REFS
failures identified by gh-124785.
(cherry picked from commit f2cb399)

Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>

* [3.13] gh-125286: Share the Main Refchain With Legacy Interpreters (gh-125709)

They used to be shared, before 3.12.  Returning to sharing them resolves a failure on Py_TRACE_REFS builds.

---------

Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
ericsnowcurrently added a commit that referenced this pull request Dec 3, 2024
[3.12] gh-116510: Fix a Crash Due to Shared Immortal Interned Strings (…
49da170 
…gh-125205)

Fix a crash caused by immortal interned strings being shared between
sub-interpreters that use basic single-phase init. In that case, the string
can be used by an interpreter that outlives the interpreter that created and
interned it. For interpreters that share obmalloc state, also share the
interned dict with the main interpreter.

This is an un-revert of gh-124646 that then addresses the Py_TRACE_REFS
failures identified by gh-124785 (i.e. backporting gh-125709 too).

(cherry picked from commit f2cb399, AKA gh-124865)

Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

nascheme nascheme left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL