[3.13] gh-116510: Fix a Crash Due to Shared Immortal Interned Strings (gh-124865) - #125204
Merged
encukou merged 2 commits intoNov 12, 2024
Merged
[3.13] gh-116510: Fix a Crash Due to Shared Immortal Interned Strings (gh-124865)#125204encukou merged 2 commits into
encukou merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…ythongh-124865) Fix a crash caused by immortal interned strings being shared between sub-interpreters that use basic single-phase init. In that case, the string can be used by an interpreter that outlives the interpreter that created and interned it. For interpreters that share obmalloc state, also share the interned dict with the main interpreter. This is an un-revert of pythongh-124646 that then addresses the Py_TRACE_REFS failures identified by pythongh-124785. (cherry picked from commit f2cb399) Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
Copy link
Copy Markdown
Member
|
Please don't merge until the TraceRefs regression is fixed: #124865 (comment) |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I think this can be merged now with GH-125709 applied on top or squashed into it. |
Sorry, something went wrong.
…ers (pythongh-125709) They used to be shared, before 3.12. Returning to sharing them resolves a failure on Py_TRACE_REFS builds.
encukou
requested review from
corona10,
ericsnowcurrently and
erlend-aasland
as code owners
November 1, 2024 13:08
encukou
reviewed
Nov 11, 2024
Comment thread
Doc/whatsnew/3.13.rst
Yhg1s
approved these changes
Nov 11, 2024
Copy link
Copy Markdown
|
Thanks @miss-islington for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Sorry, @miss-islington and @encukou, I could not cleanly backport this to 3.12 due to a conflict. cherry_picker 02cd3ce0f201df98939c65bcba8445bb0b70717b 3.12 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a crash caused by immortal interned strings being shared between
sub-interpreters that use basic single-phase init. In that case, the string
can be used by an interpreter that outlives the interpreter that created and
interned it. For interpreters that share obmalloc state, also share the
interned dict with the main interpreter.
This is an un-revert of gh-124646 that then addresses the Py_TRACE_REFS
failures identified by gh-124785.
(cherry picked from commit f2cb399)
Co-authored-by: Eric Snow ericsnowcurrently@gmail.com