FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-125843: indicate which C function caused a `curses.error` by picnixz · Pull Request #125844 · python/cpython · GitHub

/ cpython Public

gh-125843: indicate which C function caused a curses.error - #125844

Merged
picnixz merged 27 commits into
python:mainfrom
picnixz:curses/improve-error-type-125843
May 19, 2025
ConversationCommits (27)ChecksFiles changed
Merged

gh-125843: indicate which C function caused a curses.error#125844
picnixz merged 27 commits into
python:mainfrom
picnixz:curses/improve-error-type-125843

Conversation

picnixz commented Oct 22, 2024 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request Oct 22, 2024
Closed
picnixz mentioned this pull request Oct 22, 2024
Closed
picnixz marked this pull request as draft April 25, 2025 11:02
picnixz changed the title gh-125843: store the name of the curses C function or macro in curses.error gh-125843: include which C function caused a curses.error Apr 25, 2025
picnixz changed the title gh-125843: include which C function caused a curses.error gh-125843: indicate which C function caused a curses.error Apr 25, 2025
picnixz marked this pull request as ready for review April 25, 2025 19:35
picnixz commented Apr 25, 2025
View reviewed changes
Comment thread Modules/_cursesmodule.c Outdated
picnixz commented Apr 25, 2025
View reviewed changes
Comment thread Modules/_cursesmodule.c Outdated
Comment thread Modules/_cursesmodule.c Outdated
Comment thread Modules/_cursesmodule.c Outdated
Comment thread Modules/_cursesmodule.c Outdated
Comment thread Modules/_cursesmodule.c Outdated
Comment thread Modules/_cursesmodule.c
Comment thread Modules/_cursesmodule.c Outdated
Comment thread Modules/_cursesmodule.c Outdated
picnixz commented Apr 25, 2025
View reviewed changes
Comment thread Modules/_cursesmodule.c Outdated
Comment thread Modules/_cursesmodule.c Outdated
Comment thread Modules/_cursesmodule.c Outdated
Comment thread Modules/_cursesmodule.c Outdated
Comment thread Modules/_cursesmodule.c Outdated
Comment thread Modules/_cursesmodule.c Outdated
picnixz commented Apr 25, 2025
View reviewed changes

picnixz left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Actually, there are some funcname that should be corrected but I need to see how they should really be corrected.

Comment thread Modules/_cursesmodule.c Outdated
Comment thread Modules/_cursesmodule.c Outdated
Comment thread Modules/_cursesmodule.c Outdated
picnixz marked this pull request as draft April 25, 2025 19:50

picnixz commented May 7, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

I've decided to keep the explicit calls to reduce the number of helper functions. When the python function name is the same, the caller needs to pass NULL. It also avoids the _from suffixes. I also updated the _curses_panel module that I totally forgot.

Note: I can actually delay the curses_panel changes for a follow-up PR btw.

picnixz requested a review from encukou May 7, 2025 12:35
picnixz mentioned this pull request May 18, 2025
Closed

picnixz commented May 19, 2025

Copy link
Copy Markdown
Member Author

I'll make a separate PR for _curses.panel as I want to merge the curses part now.

picnixz added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 19, 2025

This comment was marked as resolved.

Sign in to view
bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 19, 2025

This comment was marked as resolved.

Sign in to view
picnixz added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 19, 2025

This comment was marked as resolved.

Sign in to view
bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 19, 2025
picnixz added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 19, 2025

bedevere-bot commented May 19, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @picnixz for commit 34a1c31 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F125844%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 19, 2025
encukou approved these changes May 19, 2025
View reviewed changes

encukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

OK, let's do it!
Thank you!

Comment thread Modules/_cursesmodule.c Outdated
Comment thread Modules/_cursesmodule.c Outdated
Comment thread Modules/_cursesmodule.c Outdated
Comment thread Modules/_cursesmodule.c Outdated
reduce overall diff
6be3a15 
Co-authored-by: Petr Viktorin <encukou@gmail.com>
picnixz merged commit ee36db5 into python:main May 19, 2025
picnixz deleted the curses/improve-error-type-125843 branch May 19, 2025 13:53

picnixz commented May 19, 2025

Copy link
Copy Markdown
Member Author

Ok, so actually I broke another build bot. However, it's good that it's broken because this means that either my function call is wrong or something else was wrong.

picnixz mentioned this pull request May 24, 2025
Merged
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythongh-125843: indicate which C function caused a curses.error (p…
0b23603 
…ython#125844)

- Rename error helpers with a `curses_set_error_*` prefix instead of `PyCurses*`.
- Cleanly report both NULL and ERR cases.
- Raise `curses.error` in `is_linetouched` instead of a `TypeError`.
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythongh-125843: indicate which C function caused a curses.error (p…
ec53a92 
…ython#125844)

- Rename error helpers with a `curses_set_error_*` prefix instead of `PyCurses*`.
- Cleanly report both NULL and ERR cases.
- Raise `curses.error` in `is_linetouched` instead of a `TypeError`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

encukou encukou approved these changes
Yhg1s Awaiting requested review from Yhg1s

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL