FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-133579: correctly report C curses errors in `_curses_panel` by picnixz · Pull Request #134629 · python/cpython · GitHub

/ cpython Public

gh-133579: correctly report C curses errors in _curses_panel - #134629

Merged
picnixz merged 10 commits into
python:mainfrom
picnixz:fix/curses/panel-better-errors-125843
Jun 8, 2025
Merged

gh-133579: correctly report C curses errors in _curses_panel#134629
picnixz merged 10 commits into
python:mainfrom
picnixz:fix/curses/panel-better-errors-125843

Conversation

picnixz commented May 24, 2025
edited
Loading

Copy link
Copy Markdown
Member

This was part of #125844 but I extracted it from there because it wasn't necessary. I'll make it part of gh-133579 instead of gh-125843 because the other one was more for curses module itself and this one is a follow-up (and also because I changed some exception types)

picnixz requested a review from encukou May 24, 2025 12:26
picnixz changed the title gh-125843: correctly report C curses errors in _curses_panel gh-133579: correctly report C curses errors in _curses_panel May 24, 2025
picnixz requested a review from vstinner May 30, 2025 13:57
Comment thread Modules/_curses_panel.c
Comment thread Modules/_curses_panel.c Outdated

encukou commented Jun 6, 2025

Copy link
Copy Markdown
Member

Looks good! Sorry for the delay.
Let's merge if the buildbots don't complain.

encukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 6, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit e6c00d0 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134629%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 6, 2025

encukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Buildbot failures are unrelated.
I don't mind keeping the comment in. Do you really want to remove it?

picnixz commented Jun 7, 2025
edited
Loading

Copy link
Copy Markdown
Member Author

Do you really want to remove it?

Not really, though I think I can remove it if we go through all modules that don't correctly assert this (but in a follow-up). In practice, I don't think it'll be an issue as such functions are internal-only, so issues would be caught at review time. We could do more expensive checks on DEBUG builds though.

I think I wanted to remove it because I expected that this issue was already well-known and that my comment could have been "too much".

picnixz self-assigned this Jun 7, 2025

encukou commented Jun 7, 2025

Copy link
Copy Markdown
Member

So let's merge this as is?
(You just assigned yourself, does that mean you want to do something more?)

picnixz commented Jun 7, 2025

Copy link
Copy Markdown
Member Author

(You just assigned yourself, does that mean you want to do something more?)

I assign the PR to myself when I want to merge it later, otherwise I forget about the PR. But if you want to merge it before, you can go ahead!

picnixz commented Jun 7, 2025

Copy link
Copy Markdown
Member Author

Also, I myself only merge stuff when I'm on Linux as I can revert or make a fast patch if something breaks just after (I'm currently on Windows since I'm playing). So usually I merge my PRs when I'm back on Linux.

picnixz merged commit d610f11 into python:main Jun 8, 2025
picnixz deleted the fix/curses/panel-better-errors-125843 branch June 8, 2025 07:10

encukou commented Jun 9, 2025

Copy link
Copy Markdown
Member

I assign the PR to myself when I want to merge it later, otherwise I forget about the PR.

Ah, got it! I'll try to remember that for later :)

Also, I myself only merge stuff when I'm on Linux as I can revert or make a fast patch if something breaks just after (I'm currently on Windows since I'm playing).

No rush. Myself, I'm only back to Linux now.
(Feel free to turn off GitHub notifications when playing; it's perfectly OK to reply a day or two later.)

lkollar pushed a commit to lkollar/cpython that referenced this pull request Jun 19, 2025
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL