Repository navigation
gh-89640: Pull in update to float word order detection in autoconf-archive - #126747
Merged
erlend-aasland merged 1 commit intoNov 13, 2024
Merged
erlend-aasland merged 1 commit into
erlend-aasland merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
I guess the check-if-autoconf-files-are-up-to-date CI also needs an update; see .github/workflows/build.yml IIRC. |
Sorry, something went wrong.
…nf-archive Pulls in the updated docker container from this PR: python/cpython-devcontainers#34 which contains the autoconf-archive PR: autoconf-archive/autoconf-archive#316 I removed the workaround from configure.ac, regenerated everything, and manually tested that the fix works.
hoodmane
force-pushed
the
update-float-word-detection
branch
from
c4cee99 to
ea9a348
Compare
November 13, 2024 10:09
Copy link
Copy Markdown
Contributor
Author
|
Okay, autoconf up to date check passes now. |
Sorry, something went wrong.
erlend-aasland
approved these changes
Nov 13, 2024
erlend-aasland
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thanks!
For future reference: we normally try to avoid force-pushing, since it can make reviewing harder.
Sorry, something went wrong.
picnixz
pushed a commit
to picnixz/cpython
that referenced
this pull request
Dec 8, 2024
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulls in the updated docker container from this PR: python/cpython-devcontainers#34 which contains the autoconf-archive PR:
autoconf-archive/autoconf-archive#316
I removed the workaround from configure.ac, regenerated everything, and manually tested that the fix works.