Update patch for ax_c_float_words_bigendian.m4 - #34
Merged
erlend-aasland merged 1 commit intoNov 11, 2024
Merged
erlend-aasland merged 1 commit into
erlend-aasland merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
The original patch: autoconf-archive/autoconf-archive#279 broke endianness detection on Emscripten. This was fixed in this followup: autoconf-archive/autoconf-archive#316 We also have worked around the problem by adjusting `configure.ac` in the Python repo to handle this case: python/cpython#126387 But it's useful for us to use the upstream autoconf-archive detection so that we can be completely sure that the fix works in practice.
Copy link
Copy Markdown
Contributor
Author
|
Apologies for the double post (with #33). |
Sorry, something went wrong.
erlend-aasland
approved these changes
Nov 11, 2024
erlend-aasland
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Thanks!
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
FTR, I started a new release: https://github.com/python/cpython-devcontainers/actions/runs/11786316759 |
Sorry, something went wrong.
hoodmane
added a commit
to hoodmane/cpython
that referenced
this pull request
Nov 12, 2024
…nf-archive Pulls in the updated docker container from this PR: python/cpython-devcontainers#34 which contains the autoconf-archive PR: autoconf-archive/autoconf-archive#316 I removed the workaround from configure.ac, regenerated everything, and manually tested that the fix works.
hoodmane
added a commit
to hoodmane/cpython
that referenced
this pull request
Nov 13, 2024
…nf-archive Pulls in the updated docker container from this PR: python/cpython-devcontainers#34 which contains the autoconf-archive PR: autoconf-archive/autoconf-archive#316 I removed the workaround from configure.ac, regenerated everything, and manually tested that the fix works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original patch:
autoconf-archive/autoconf-archive#279 broke endianness detection on Emscripten. This was fixed in this followup: autoconf-archive/autoconf-archive#316
We also have worked around the problem by adjusting configure.ac in the Python repo to handle this case:
python/cpython#126387
But it's useful for us to use the upstream autoconf-archive detection so that we can be completely sure that the fix works in practice.
cc @erlend-aasland