Repository navigation
GH-115869: Make jit_stencils.h reproducible - #127166
Merged
brandtbucher merged 6 commits intoNov 24, 2024
Merged
brandtbucher merged 6 commits into
brandtbucher merged 6 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
brandtbucher
commented
Nov 22, 2024
Comment thread
Tools/jit/_stencils.py
| offset = len(self.body) | ||
| padding = -offset % alignment | ||
| self.disassembly.append(f"{offset:x}: {' '.join(['00'] * padding)}") | ||
| if padding: |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
This is an unrelated cleanup.
Sorry, something went wrong.
mdboom
approved these changes
Nov 23, 2024
savannahostrowski
approved these changes
Nov 24, 2024
savannahostrowski
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
bmwiedemann
added a commit
to bmwiedemann/cpython
that referenced
this pull request
Jul 31, 2026
…ythonGH-127166) llvm-objdump prints the path of the object file it disassembles, and the JIT builds every stencil in a fresh tempfile.TemporaryDirectory(). That random path ended up verbatim in the disassembly comments of the generated jit_stencils.h, so two builds of the same source never produced the same header: // /tmp/tmp164olvmi/_BINARY_OP.o: file format elf64-x86-64 +// /tmp/tmpmufvewt2/_BINARY_OP.o: file format elf64-x86-64 Replace the full path with the bare file name. Only the _parse() hunk of that commit is taken here; the rest of it depends on refactorings that are not in 3.13. (cherry picked from commit 17c16ae) Co-authored-by: Brandt Bucher <brandtbucher@microsoft.com>
bmwiedemann
added a commit
to bmwiedemann/cpython
that referenced
this pull request
Jul 31, 2026
Keep the build tmpdir out of jit_stencils.h (pythonGH-127166) llvm-objdump prints the path of the object file it disassembles, and the JIT builds every stencil in a fresh tempfile.TemporaryDirectory(). That random path ended up verbatim in the disassembly comments of the generated jit_stencils.h, so two builds of the same source never produced the same header: // /tmp/tmp164olvmi/_BINARY_OP.o: file format elf64-x86-64 +// /tmp/tmpmufvewt2/_BINARY_OP.o: file format elf64-x86-64 Replace the full path with the bare file name. Only the _parse() hunk of that commit is taken here; the rest of it depends on refactorings that are not in 3.13. (cherry picked from commit 17c16ae) Co-authored-by: Brandt Bucher <brandtbucher@microsoft.com>
bmwiedemann
added a commit
to bmwiedemann/cpython
that referenced
this pull request
Jul 31, 2026
…7166) Keep the build tmpdir out of jit_stencils.h llvm-objdump prints the path of the object file it disassembles, and the JIT builds every stencil in a fresh tempfile.TemporaryDirectory(). That random path ended up verbatim in the disassembly comments of the generated jit_stencils.h, so two builds of the same source never produced the same header: // /tmp/tmp164olvmi/_BINARY_OP.o: file format elf64-x86-64 +// /tmp/tmpmufvewt2/_BINARY_OP.o: file format elf64-x86-64 Replace the full path with the bare file name. Only the _parse() hunk of that commit is taken here; the rest of it depends on refactorings that are not in 3.13. (cherry picked from commit 17c16ae) Co-authored-by: Brandt Bucher <brandtbucher@microsoft.com>
Copy link
Copy Markdown
|
GH-154988 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
bmwiedemann
added a commit
to bmwiedemann/cpython
that referenced
this pull request
Jul 31, 2026
…7166) Keep the build tmpdir out of jit_stencils.h llvm-objdump prints the path of the object file it disassembles, and the JIT builds every stencil in a fresh tempfile.TemporaryDirectory(). That random path ended up verbatim in the disassembly comments of the generated jit_stencils.h, so two builds of the same source never produced the same header: // /tmp/tmp164olvmi/_BINARY_OP.o: file format elf64-x86-64 +// /tmp/tmpmufvewt2/_BINARY_OP.o: file format elf64-x86-64 Replace the full path with the bare file name. Only the _parse() hunk of that commit is taken here; the rest of it depends on refactorings that are not in 3.13. (cherry picked from commit 17c16ae) Co-authored-by: Brandt Bucher <brandtbucher@microsoft.com>
bmwiedemann
added a commit
to bmwiedemann/cpython
that referenced
this pull request
Jul 31, 2026
…7166) Keep the build tmpdir out of jit_stencils.h llvm-objdump prints the path of the object file it disassembles, and the JIT builds every stencil in a fresh tempfile.TemporaryDirectory(). That random path ended up verbatim in the disassembly comments of the generated jit_stencils.h, so two builds of the same source never produced the same header: // /tmp/tmp164olvmi/_BINARY_OP.o: file format elf64-x86-64 +// /tmp/tmpmufvewt2/_BINARY_OP.o: file format elf64-x86-64 Replace the full path with the bare file name. Only the _parse() hunk of that commit is taken here; the rest of it depends on refactorings that are not in 3.13. (cherry picked from commit 17c16ae) Co-authored-by: Brandt Bucher <brandtbucher@microsoft.com>
Yhg1s
pushed a commit
that referenced
this pull request
Aug 4, 2026
Keep the build tmpdir out of jit_stencils.h
llvm-objdump prints the path of the object file it disassembles, and the
JIT builds every stencil in a fresh tempfile.TemporaryDirectory(). That
random path ended up verbatim in the disassembly comments of the
generated jit_stencils.h, so two builds of the same source never produced
the same header:
// /tmp/tmp164olvmi/_BINARY_OP.o: file format elf64-x86-64
+// /tmp/tmpmufvewt2/_BINARY_OP.o: file format elf64-x86-64
Replace the full path with the bare file name.
Only the _parse() hunk of that commit is taken here; the rest of it
depends on refactorings that are not in 3.13.
(cherry picked from commit 17c16ae)
Co-authored-by: Brandt Bucher <brandtbucher@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the core dev sprint, we discussed the possibility of hosting pre-built jit_stencils.h files for common platforms and build configurations.
While there's a lot of work involved in making that happen (I'll post a rough plan shortly), this is the first logical step in that direction. This PR replaces absolute file paths in the generated code with relative ones, and processes stencils in sorted order.