Repository navigation
[3.13] GH-115869: Make jit_stencils.h reproducible (GH-127166) - #154988
Merged
Yhg1s merged 1 commit intoAug 4, 2026
Merged
Yhg1s merged 1 commit into
Yhg1s merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
bmwiedemann
requested review from
brandtbucher and
savannahostrowski
as code owners
July 31, 2026 10:45
mcepl
reviewed
Jul 31, 2026
mcepl
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Make sense to me.
Sorry, something went wrong.
…7166) Keep the build tmpdir out of jit_stencils.h llvm-objdump prints the path of the object file it disassembles, and the JIT builds every stencil in a fresh tempfile.TemporaryDirectory(). That random path ended up verbatim in the disassembly comments of the generated jit_stencils.h, so two builds of the same source never produced the same header: // /tmp/tmp164olvmi/_BINARY_OP.o: file format elf64-x86-64 +// /tmp/tmpmufvewt2/_BINARY_OP.o: file format elf64-x86-64 Replace the full path with the bare file name. Only the _parse() hunk of that commit is taken here; the rest of it depends on refactorings that are not in 3.13. (cherry picked from commit 17c16ae) Co-authored-by: Brandt Bucher <brandtbucher@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the build tmpdir out of jit_stencils.h
llvm-objdump prints the path of the object file it disassembles, and the JIT builds every stencil in a fresh tempfile.TemporaryDirectory(). That random path ended up verbatim in the disassembly comments of the generated jit_stencils.h, so two builds of the same source never produced the same header:
Replace the full path with the bare file name.
Only the _parse() hunk of that commit is taken here; the rest of it depends on refactorings that are not in 3.13.
(cherry picked from commit 17c16ae)
I tested that it works.
This PR was done while working on reproducible builds for openSUSE.