GH-125413: Revert addition of pathlib.Path.scandir() method - #127377
Merged
barneygale merged 4 commits intoDec 5, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Remove documentation for `pathlib.Path.scandir()`, and rename the method to `_scandir()`. In the private pathlib ABCs, make `iterdir()` abstract and call it from `_scandir()`. It's not worthwhile to add this method at the moment - see discussion: https://discuss.python.org/t/ergonomics-of-new-pathlib-path-scandir/71721
zooba
reviewed
Nov 29, 2024
zooba
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Sorry, I think we need a bit more code duplication in order to keep subclassing reliable.
Sorry, something went wrong.
Comment thread
Lib/pathlib/_abc.py
Comment thread
Lib/pathlib/_abc.py
Comment thread
Lib/pathlib/_abc.py
Comment thread
Misc/NEWS.d/next/Library/2024-11-29-00-15-59.gh-issue-125413.WCN0vv.rst
Outdated
Copy link
Copy Markdown
Contributor
Author
|
@zooba would you mind if I tackle removing _scandir() in a follow-up PR? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Sure. Provided it's not part of the public/subclassing interface, I'm happy. |
Sorry, something went wrong.
…CN0vv.rst Co-authored-by: Steve Dower <steve.dower@microsoft.com>
zooba
approved these changes
Dec 5, 2024
barneygale
enabled auto-merge (squash)
December 5, 2024 21:36
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Jan 8, 2025
…ython#127377) Remove documentation for `pathlib.Path.scandir()`, and rename the method to `_scandir()`. In the private pathlib ABCs, make `iterdir()` abstract and call it from `_scandir()`. It's not worthwhile to add this method at the moment - see discussion: https://discuss.python.org/t/ergonomics-of-new-pathlib-path-scandir/71721 Co-authored-by: Steve Dower <steve.dower@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove documentation for pathlib.Path.scandir(), and rename the method to _scandir(). In the private pathlib ABCs, make iterdir() abstract and call it from _scandir().
It's not worthwhile to add this method at the moment - see discussion: https://discuss.python.org/t/ergonomics-of-new-pathlib-path-scandir/71721
📚 Documentation preview 📚: https://cpython-previews--127377.org.readthedocs.build/