FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-125413: Add `pathlib.Path.info` attribute by barneygale · Pull Request #127730 · python/cpython · GitHub

/ cpython Public

GH-125413: Add pathlib.Path.info attribute - #127730

Merged
barneygale merged 43 commits into
python:mainfrom
barneygale:gh-125413-info
Feb 8, 2025
ConversationCommits (43)ChecksFiles changed
Merged

GH-125413: Add pathlib.Path.info attribute#127730
barneygale merged 43 commits into
python:mainfrom
barneygale:gh-125413-info

Conversation

barneygale commented Dec 7, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Add pathlib.Path.info attribute, which stores an object implementing the pathlib.types.PathInfo protocol (also new). The object supports querying the file type and internally caching os.stat() results. Path objects generated by Path.iterdir() are initialised with status information from os.DirEntry objects, which is gleaned from scanning the parent directory.

The PathInfo protocol has four methods: exists(), is_dir(), is_file() and is_symlink().

pythonGH-125413: pathlib ABCs: replace _scandir() with _info
6046a27 
When a path object is generated by `PathBase.iterdir()`, then its `_info`
attribute now stores a `os.DirEntry`-like object that can be used to query
the file type. This removes any need for a `_scandir()` method.

Currently the `_info` attribute is private and only guaranteed to be
populated in paths from `iterdir()`. Later on, I'm hoping to rename it to
`info` and ensure that it's populated for all kinds of paths (this probably
involves adding a `pathlib.FileInfo` class.) In the pathlib ABCs, `info`
will replace `stat()` as the lowest-level abstract file status querying
mechanism.
bedevere-app Bot mentioned this pull request Dec 7, 2024
Closed
barneygale requested a review from zooba December 7, 2024 23:36

barneygale commented Dec 8, 2024

Copy link
Copy Markdown
Contributor Author

Steve - hopefully this helps address the issues you raised in #127377, but perhaps I'm only moving the problem around here.

zooba commented Dec 9, 2024

Copy link
Copy Markdown
Member

I think this is just moving stuff around. It might end up being the right places, but let's see the Discourse discussion play out a bit first.

barneygale changed the title GH-125413: pathlib ABCs: replace _scandir() with _info GH-125413: pathlib ABCs: replace _scandir() with _status Dec 9, 2024
barneygale changed the title GH-125413: pathlib ABCs: replace _scandir() with _status GH-125413: Add pathlib.Path.status attribute Dec 9, 2024
barneygale marked this pull request as draft December 9, 2024 20:58

barneygale commented Dec 9, 2024

Copy link
Copy Markdown
Contributor Author

I've revised the PR to be a more complete implementation of what I described on the forum, mostly as a demonstration/proof-of-concept at this stage.

barneygale added the type-feature A feature request or enhancement label Dec 9, 2024
barneygale requested a review from ncoghlan December 17, 2024 09:57

barneygale commented Dec 17, 2024

Copy link
Copy Markdown
Contributor Author

Right, I think this is ready for review. Alyssa, sorry if this seems like deja-vu!

barneygale changed the title GH-125413: Add pathlib.Path.status attribute GH-125413: Add pathlib.Path.info attribute Dec 21, 2024
barneygale mentioned this pull request Jan 5, 2025
Open
17 tasks
encukou reviewed Jan 10, 2025
View reviewed changes

encukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This looks great, thank you!
I do have a nitpick:

Comment thread Lib/pathlib/_local.py Outdated
barneygale and others added 2 commits January 10, 2025 17:16

barneygale commented Jan 14, 2025

Copy link
Copy Markdown
Contributor Author

Thank you Petr :) I'll wait another month until I merge, in case Alyssa or Steve have feedback

barneygale commented Feb 4, 2025

Copy link
Copy Markdown
Contributor Author

I'll merge this on Friday if there's no further feedback. Cheers

barneygale merged commit 718ab66 into python:main Feb 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

encukou encukou approved these changes
zooba Awaiting requested review from zooba
ncoghlan Awaiting requested review from ncoghlan

Assignees

No one assigned

Labels

topic-pathlib type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL