gh-127718: Add colour to test.regrtest output - #127719
Merged
hugovk merged 4 commits intoDec 10, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
error: Name state is not defined [name-defined]
error: Cannot find implementation or library stub for module named _colorize [import-not-found]
sobolevn
reviewed
Dec 9, 2024
sobolevn
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Do we need to test this? We have https://github.com/python/cpython/blob/main/Lib/test/test_regrtest.py file where this might fit.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I've added some tests. |
Sorry, something went wrong.
sobolevn
reviewed
Dec 9, 2024
sobolevn
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM! Thanks!
Sorry, something went wrong.
Eclips4
approved these changes
Dec 9, 2024
Eclips4
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM.
Thank you Hugo for coloring unittest and our test suite!
Sorry, something went wrong.
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Jan 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Examples:
📚 Documentation preview 📚: https://cpython-previews--127719.org.readthedocs.build/en/127719/library/test.html#module-test.regrtest