FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add colour to GitHub Actions output by hugovk · Pull Request #129196 · python/cpython · GitHub

/ cpython Public

Add colour to GitHub Actions output - #129196

Merged
hugovk merged 2 commits into
python:mainfrom
hugovk:3.14-ci-colour
Jan 22, 2025
ConversationCommits (2)ChecksFiles changed
Merged

Add colour to GitHub Actions output#129196
hugovk merged 2 commits into
python:mainfrom
hugovk:3.14-ci-colour

Conversation

hugovk commented Jan 22, 2025

Copy link
Copy Markdown
Member

Following the merge of #127223, #127719, #127877, #128498 and #128687, we can now enable colour in the unittest and test.regrtest output on GitHub Actions using FORCE_COLOR.

The biggest benefit is it helps us find failures when scrolling the long logs, and usually the reason to open the logs in the first place is to find a failure.

For example, here's a forced failure in another branch:

https://github.com/hugovk/cpython/actions/runs/12915439756/job/36017613160

Accessibility check: it's important not to rely on colour alone to confer information, and the current textual output is not changed, and continues to say pass/skip/fail as now. The colour is an addition.

brandtbucher approved these changes Jan 22, 2025
View reviewed changes

brandtbucher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

JIT CI changes look good!

AA-Turner approved these changes Jan 22, 2025
View reviewed changes
Comment thread .github/workflows/reusable-macos.yml Outdated

hugovk commented Jan 22, 2025

Copy link
Copy Markdown
Member Author

Thank you flaky test, it was easy to find you and conclude not relevant here, and restart the job :)

https://github.com/python/cpython/actions/runs/12916819582/job/36021859818?pr=129196

hugovk enabled auto-merge (squash) January 22, 2025 21:13

hugovk commented Jan 22, 2025

Copy link
Copy Markdown
Member Author

unittest and test.regrtest don't have colour in 3.13 or earlier, but let's backport these to keep the diffs between the files smaller for future backports, and it can enable colour in any other tools on the CI that support it.

hugovk added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jan 22, 2025
hugovk merged commit 298dda5 into python:main Jan 22, 2025
hugovk deleted the 3.14-ci-colour branch January 22, 2025 21:22

miss-islington-app Bot commented Jan 22, 2025

Copy link
Copy Markdown

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 22, 2025
Add colour to GitHub Actions output (pythonGH-129196)
bf68ad3 
(cherry picked from commit 298dda5)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

bedevere-app Bot commented Jan 22, 2025

Copy link
Copy Markdown

GH-129198 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jan 22, 2025

miss-islington-app Bot commented Jan 22, 2025

Copy link
Copy Markdown

Sorry, @hugovk, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 298dda57709c45cbcb44831e0d682dc071af5293 3.12

hugovk added a commit to hugovk/cpython that referenced this pull request Jan 22, 2025
[3.12] Add colour to GitHub Actions output (pythonGH-129196)
e58af3e 
(cherry picked from commit 298dda5)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

bedevere-app Bot commented Jan 22, 2025

Copy link
Copy Markdown

GH-129199 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jan 22, 2025
hugovk added a commit that referenced this pull request Jan 22, 2025
[3.13] Add colour to GitHub Actions output (GH-129196) (#129198)
d674792 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
hugovk added a commit that referenced this pull request Jan 22, 2025
[3.12] Add colour to GitHub Actions output (GH-129196) (#129199)
880ad18
hugovk mentioned this pull request Jan 25, 2025
Merged
hugovk mentioned this pull request Apr 14, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AA-Turner AA-Turner approved these changes
ezio-melotti ezio-melotti approved these changes
brandtbucher brandtbucher approved these changes
savannahostrowski Awaiting requested review from savannahostrowski savannahostrowski is a code owner

Assignees

hugovk

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL