[3.12] Add zizmor to pre-commit and fix most findings (GH-127749) - #127788
Merged
hugovk merged 7 commits intoDec 10, 2024
Merged
[3.12] Add zizmor to pre-commit and fix most findings (GH-127749)#127788hugovk merged 7 commits into
hugovk merged 7 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
(cherry picked from commit ae31df3) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Comment thread
.github/workflows/reusable-windows.yml
Comment thread
.github/workflows/reusable-windows.yml
Outdated
Comment thread
.github/workflows/reusable-windows.yml
Outdated
Comment thread
.github/workflows/reusable-windows.yml
ezio-melotti
approved these changes
Dec 10, 2024
Copy link
Copy Markdown
Member
Author
|
Thanks @ezio-melotti for fixing this up :) |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
GitHub won't let me merge this right now: "Merge already in progress". Let's try later... |
Sorry, something went wrong.
AlexWaygood
reviewed
Dec 10, 2024
AlexWaygood
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
One more Windows workflow where I think you need to specify shell: bash. Not sure why it's not failing on this PR but I think we should specify bash anyway:
Sorry, something went wrong.
Comment thread
.github/workflows/reusable-windows-msi.yml
Outdated
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
hugovk
added a commit
to hugovk/cpython
that referenced
this pull request
Dec 10, 2024
… (python#127788) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com> Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
hugovk
enabled auto-merge (squash)
December 10, 2024 14:29
AlexWaygood
reviewed
Dec 10, 2024
Comment thread
.github/workflows/reusable-windows-msi.yml
Outdated
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit ae31df3)