FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

CI: Use bash to properly expand variable by hugovk · Pull Request #127822 · python/cpython · GitHub

/ cpython Public

CI: Use bash to properly expand variable - #127822

Merged
hugovk merged 1 commit into
python:mainfrom
hugovk:ci-windows-ci-shell-bash
Dec 11, 2024
ConversationCommits (1)ChecksFiles changed
Merged

CI: Use bash to properly expand variable#127822
hugovk merged 1 commit into
python:mainfrom
hugovk:ci-windows-ci-shell-bash

Conversation

hugovk commented Dec 11, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Follow on from #127749.

Re: #127786 (comment).

Needs backporting to 3.13 but was already added to 3.12 in #127788.

hugovk added skip issue skip news needs backport to 3.13 bugs and security fixes infra CI, GitHub Actions, buildbots, Dependabot, etc. labels Dec 11, 2024
hugovk requested a review from ezio-melotti as a code owner December 11, 2024 12:32
hugovk mentioned this pull request Dec 11, 2024
Merged
AlexWaygood approved these changes Dec 11, 2024
View reviewed changes

AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

ezio-melotti approved these changes Dec 11, 2024
View reviewed changes
Comment thread .github/workflows/reusable-windows-msi.yml
persist-credentials: false
- name: Build CPython installer
run: .\Tools\msi\build.bat --doc -"${ARCH}"
run: ./Tools/msi/build.bat --doc -"${ARCH}"

ezio-melotti Dec 11, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It seems that with shell: bash both / and \\ work for paths, but not \.
I've seen (and used) \\ elsewhere, but since this is the only instance in this file and / is more readable we don't need to worry about consistency here.

AlexWaygood Dec 11, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yes, / and \\ are both valid path separators on Windows, so using / always works fine for paths on Windows. The difference between the platforms is that / is not the default path separator on Windows.

hugovk enabled auto-merge (squash) December 11, 2024 12:48
hugovk merged commit b2ad7e0 into python:main Dec 11, 2024
hugovk deleted the ci-windows-ci-shell-bash branch December 11, 2024 12:57

miss-islington-app Bot commented Dec 11, 2024

Copy link
Copy Markdown

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 11, 2024
CI: Use bash to properly expand variable (pythonGH-127822)
7013eed 
(cherry picked from commit b2ad7e0)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

bedevere-app Bot commented Dec 11, 2024

Copy link
Copy Markdown

GH-127824 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Dec 11, 2024
AlexWaygood pushed a commit that referenced this pull request Dec 11, 2024
[3.13] CI: Use bash to properly expand variable (GH-127822) (#127824)
f56da92 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
CI: Use bash to properly expand variable (python#127822)
584906a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AlexWaygood AlexWaygood approved these changes
ezio-melotti ezio-melotti approved these changes

Assignees

No one assigned

Labels

infra CI, GitHub Actions, buildbots, Dependabot, etc. skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL