Repository navigation
gh-128030: Avoid error from PyModule_GetFilenameObject for non-module - #128047
Merged
hauntsaninja merged 3 commits intoDec 20, 2024
Merged
hauntsaninja merged 3 commits into
hauntsaninja merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…module I missed the extra `PyModule_Check` in python#127660 because I was looking at 3.12 as the base implementation for import from. This meant that I missed the `PyModuleCheck` introduced in python#112661.
hauntsaninja
requested review from
brettcannon,
ericsnowcurrently,
markshannon,
ncoghlan and
warsaw
as code owners
December 17, 2024 22:25
brettcannon
approved these changes
Dec 18, 2024
Copy link
Copy Markdown
|
Thanks @hauntsaninja for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 20, 2024
…module (pythonGH-128047) I missed the extra `PyModule_Check` in pythonGH-127660 because I was looking at 3.12 as the base implementation for import from. This meant that I missed the `PyModuleCheck` introduced in pythonGH-112661. (cherry picked from commit 45e6dd6) Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
Copy link
Copy Markdown
|
GH-128114 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
hauntsaninja
added a commit
that referenced
this pull request
Dec 20, 2024
…-module (GH-128047) (#128114) gh-128030: Avoid error from PyModule_GetFilenameObject for non-module (GH-128047) I missed the extra `PyModule_Check` in GH-127660 because I was looking at 3.12 as the base implementation for import from. This meant that I missed the `PyModuleCheck` introduced in GH-112661. (cherry picked from commit 45e6dd6) Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
Copy link
Copy Markdown
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot aarch64 RHEL8 LTO + PGO 3.x has failed when building commit 45e6dd6. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/#/builders/78/builds/8070 Summary of the results of the build (if available): == Click to see traceback logsTraceback (most recent call last):
File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/threading.py", line 1054, in _bootstrap_inner
self.run()
~~~~~~~~^^
File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/threading.py", line 996, in run
self._target(*self._args, **self._kwargs)
~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/test/test_interpreters/test_stress.py", line 30, in task
interp = interpreters.create()
File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/test/support/interpreters/__init__.py", line 76, in create
id = _interpreters.create(reqrefs=True)
interpreters.InterpreterError: interpreter creation failed
k
|
Sorry, something went wrong.
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Dec 23, 2024
…module (python#128047) I missed the extra `PyModule_Check` in python#127660 because I was looking at 3.12 as the base implementation for import from. This meant that I missed the `PyModuleCheck` introduced in python#112661.
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Jan 8, 2025
…module (python#128047) I missed the extra `PyModule_Check` in python#127660 because I was looking at 3.12 as the base implementation for import from. This meant that I missed the `PyModuleCheck` introduced in python#112661.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I missed the extra PyModule_Check in #127660 because I was looking at 3.12 as the base implementation for import from. This meant that I missed the PyModuleCheck introduced in #112661 (see here).