Repository navigation
[3.13] gh-128030: Avoid error from PyModule_GetFilenameObject for non-module (GH-128047) - #128114
Merged
hauntsaninja merged 1 commit intoDec 20, 2024
Merged
hauntsaninja merged 1 commit into
hauntsaninja merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…module (pythonGH-128047) I missed the extra `PyModule_Check` in pythonGH-127660 because I was looking at 3.12 as the base implementation for import from. This meant that I missed the `PyModuleCheck` introduced in pythonGH-112661. (cherry picked from commit 45e6dd6) Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
miss-islington
requested review from
brettcannon,
ericsnowcurrently,
markshannon,
ncoghlan and
warsaw
as code owners
December 20, 2024 08:22
This was referenced Dec 20, 2024
hauntsaninja
enabled auto-merge (squash)
December 20, 2024 08:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I missed the extra PyModule_Check in GH-127660 because I was looking at
3.12 as the base implementation for import from. This meant that I
missed the PyModuleCheck introduced in GH-112661.
(cherry picked from commit 45e6dd6)
Co-authored-by: Shantanu 12621235+hauntsaninja@users.noreply.github.com