| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Sorry, something went wrong.
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
There was a problem hiding this comment.
LGTM in general, with few concerns.
Sorry, something went wrong.
|
Thank you for reviewing the PR. I looked through your mentioned pull request an noticed that the call to append_history_file is wrapped in except (FileNotFoundError, PermissionError) exception handler, thus still prone to the same read-only file system error, or am I missing something? Will it be better, that I add OSError to the except (FileNotFoundError, PermissionError) in the site.py (where the write_history_file is called) with a warning message and leave its implementation as it was? In that way file handling code in both write_history_file and append_history_file methods will match. |
Sorry, something went wrong.
Now I also catch OSError like in your pr.
Hmm, maybe. (BTW I doubt that FileNotFoundError is relevant at all.) |
Sorry, something went wrong.
|
I've changed my implementation and moved error handling to the site.py. Regarding the the FileNotFoundError being caught, I think that it is relevant for missing directories in the history file path. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
As suggested in the comment of the linked issue by @ZeroIntensity, I simply handled the exception with a resulting warning.