FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-128066: Properly handle history file writes for RO fs on PyREPL by feoh · Pull Request #134380 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-128066: Properly handle history file writes for RO fs on PyREPL - #134380

Merged
ambv merged 7 commits into
python:mainfrom
feoh:cpatti_issue_128066
May 20, 2025
ConversationCommits (7)ChecksFiles changed
Merged

gh-128066: Properly handle history file writes for RO fs on PyREPL#134380
ambv merged 7 commits into
python:mainfrom
feoh:cpatti_issue_128066

Conversation

feoh commented May 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

python-cla-bot Bot commented May 20, 2025 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

bedevere-app Bot mentioned this pull request May 20, 2025
Closed

bedevere-app Bot commented May 20, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bedevere-app Bot commented May 20, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

ambv changed the title gh-128066: Properly handle history file writes for RO fs on PyRepl gh-128066: Properly handle history file writes for RO fs on PyREPL May 20, 2025
ambv mentioned this pull request May 20, 2025
Closed
ambv merged commit c91ad5d into python:main May 20, 2025
ambv added the needs backport to 3.14 bugs and security fixes label May 20, 2025

miss-islington-app Bot commented May 20, 2025

Copy link
Copy Markdown

Thanks @feoh for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2025
pythongh-128066: Properly handle history file writes for RO fs on PyR…
4c7726f 
…EPL (pythongh-134380)

(cherry picked from commit c91ad5d)

Co-authored-by: Chris Patti <feoh@feoh.org>
Co-authored-by: Łukasz Langa <lukasz@langa.pl>

bedevere-app Bot commented May 20, 2025

Copy link
Copy Markdown

GH-134385 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 20, 2025
ambv added the needs backport to 3.13 only security fixes label May 20, 2025

miss-islington-app Bot commented May 20, 2025

Copy link
Copy Markdown

Thanks @feoh for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington-app Bot commented May 20, 2025

Copy link
Copy Markdown

Sorry, @feoh and @ambv, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker c91ad5da9d92eac4718e4da8d53689c3cc24535e 3.13

ambv added a commit to ambv/cpython that referenced this pull request May 20, 2025
[3.13] pythongh-128066: Properly handle history file writes for RO fs…
d6a3cdc 
… on PyREPL (pythongh-134380)

(cherry picked from commit c91ad5d)

Co-authored-by: Chris Patti <feoh@feoh.org>
Co-authored-by: Łukasz Langa <lukasz@langa.pl>

bedevere-app Bot commented May 20, 2025

Copy link
Copy Markdown

GH-134386 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 20, 2025
ambv added a commit that referenced this pull request May 20, 2025
[3.14] gh-128066: Properly handle history file writes for RO fs on Py…
379805d 
…REPL (gh-134380) (gh-134385)

(cherry picked from commit c91ad5d)

Co-authored-by: Chris Patti <feoh@feoh.org>
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
ambv added a commit that referenced this pull request May 20, 2025
[3.13] gh-128066: Properly handle history file writes for RO fs on Py…
b41e7b1 
…REPL (gh-134380) (gh-134386)

(cherry picked from commit c91ad5d)

Co-authored-by: Chris Patti <feoh@feoh.org>
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
lkollar pushed a commit to lkollar/cpython that referenced this pull request May 26, 2025
pythongh-128066: Properly handle history file writes for RO fs on PyR…
d251f8d 
…EPL (pythongh-134380)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythongh-128066: Properly handle history file writes for RO fs on PyR…
aa0f8bf 
…EPL (pythongh-134380)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythongh-128066: Properly handle history file writes for RO fs on PyR…
3fbcbbe 
…EPL (pythongh-134380)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
gostak-dd pushed a commit to gostak-dd/cpython that referenced this pull request Jun 2, 2026
pythongh-128066: Properly handle history file writes for RO fs on PyR…
b3e8060 
…EPL (pythongh-134380)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

FFY00 Awaiting requested review from FFY00 FFY00 is a code owner
pablogsal Awaiting requested review from pablogsal pablogsal is a code owner
lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner
ambv Awaiting requested review from ambv ambv is a code owner

Assignees

ambv

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL