FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-127146: Fix test_sysconfidata_json in Emscripten by hoodmane · Pull Request #128545 · python/cpython · GitHub

/ cpython Public

gh-127146: Fix test_sysconfidata_json in Emscripten - #128545

Closed
hoodmane wants to merge 1 commit into
python:mainfrom
hoodmane:sysconfig-test
Closed

gh-127146: Fix test_sysconfidata_json in Emscripten#128545
hoodmane wants to merge 1 commit into
python:mainfrom
hoodmane:sysconfig-test

Conversation

hoodmane commented Jan 6, 2025
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

In emscripten, the prefix is different when we build and generate the json file from when we run the test.

The prefix is different when we build from when we run the test.
hoodmane requested a review from FFY00 as a code owner January 6, 2025 12:58
bedevere-app Bot added the tests Tests in the Lib/test dir label Jan 6, 2025
hoodmane requested review from freakboy3742 and removed request for FFY00 January 6, 2025 12:58

FFY00 commented Jan 6, 2025

Copy link
Copy Markdown
Member

The prefixes should be loaded from the Makefile when cross-compiling, which we detect from _PYTHON_PROJECT_BASE being set, which should be the case in make test.

Does sys.base_prefix ever differ from the Makefile value? I am not entirely sure how the Python "installation" works on Emscripten's virtual file system. Can it be present/mounted/installed(?) on a directory other than the one specified in the Makefile? If so, and if that's where this problem stems from, then this isn't an issue specific to Emscripten, but rather all relocatable installations, which is something this test currently does not account for, but it probably should. If this is the problem, then I'd prefer to fix the underlying issue rather than special-case Emscripten.

hoodmane commented Jan 6, 2025
edited
Loading

Copy link
Copy Markdown
Contributor Author

I think I found the problem.

hoodmane closed this Jan 6, 2025

hoodmane commented Jan 6, 2025

Copy link
Copy Markdown
Contributor Author

Opened #128556 with an actual fix.

hoodmane deleted the sysconfig-test branch January 6, 2025 19:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL