FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-127146: Fix test_sysconfigdata_json for Emscripten by hoodmane · Pull Request #128556 · python/cpython · GitHub

/ cpython Public

gh-127146: Fix test_sysconfigdata_json for Emscripten - #128556

Merged
FFY00 merged 1 commit into
python:mainfrom
hoodmane:sysconfig-test-2
Jan 6, 2025
Merged

gh-127146: Fix test_sysconfigdata_json for Emscripten#128556
FFY00 merged 1 commit into
python:mainfrom
hoodmane:sysconfig-test-2

Conversation

hoodmane commented Jan 6, 2025
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

We should set the value of prefix and exec_prefix in the host from host_prefix and host_exec_prefix.

We should set the value of prefix and exec_prefix in the host from
host_prefix and host_exec_prefix.

FFY00 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ah! Yes, I was just looking at this too when working on GH-128558. Good catch!

FFY00 merged commit b6c919b into python:main Jan 6, 2025
hoodmane deleted the sysconfig-test-2 branch January 6, 2025 20:04
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025

Copy link
Copy Markdown
Contributor Author

@Fy00 I'm still getting an error with a diff like:

-  'py_version_short': '3.14'}
+  'py_version_short': '3.14',
?                            ^
+  'userbase': '/home/rchatham/.local'}

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL