Repository navigation
gh-97850: Suggest TraversableResources as the alternative for ResourceLoader. - #128601
Merged
brettcannon merged 1 commit intoJan 15, 2025
Merged
brettcannon merged 1 commit into
brettcannon merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Previously, ResourceReader was the suggested alternative, but it is itself deprecated in favour of TraversableResources.
tomasr8
requested review from
brettcannon,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
January 7, 2025 23:21
25 of 31 tasks
StanFromIreland
approved these changes
Jan 8, 2025
brettcannon
approved these changes
Jan 15, 2025
Copy link
Copy Markdown
|
Thanks @tomasr8 for the PR, and @brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 15, 2025
… `ResourceLoader` (pythonGH-128601) Suggest TraversableResources as the alternative for ResourceLoader. Previously, ResourceReader was the suggested alternative, but it is itself deprecated in favour of TraversableResources. (cherry picked from commit 256d6d2) Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
Copy link
Copy Markdown
|
GH-128895 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 15, 2025
… `ResourceLoader` (pythonGH-128601) Suggest TraversableResources as the alternative for ResourceLoader. Previously, ResourceReader was the suggested alternative, but it is itself deprecated in favour of TraversableResources. (cherry picked from commit 256d6d2) Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
Copy link
Copy Markdown
|
GH-128896 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
brettcannon
pushed a commit
that referenced
this pull request
Jan 15, 2025
…r `ResourceLoader` (GH-128601) (GH-128895) gh-97850: Suggest `TraversableResources` as the alternative for `ResourceLoader` (GH-128601) Suggest TraversableResources as the alternative for ResourceLoader. Previously, ResourceReader was the suggested alternative, but it is itself deprecated in favour of TraversableResources. (cherry picked from commit 256d6d2) Co-authored-by: Tomas R <tomas.roun8@gmail.com>
brettcannon
pushed a commit
that referenced
this pull request
Jan 15, 2025
…r `ResourceLoader` (GH-128601) (GH-128896) gh-97850: Suggest `TraversableResources` as the alternative for `ResourceLoader` (GH-128601) Suggest TraversableResources as the alternative for ResourceLoader. Previously, ResourceReader was the suggested alternative, but it is itself deprecated in favour of TraversableResources. (cherry picked from commit 256d6d2) Co-authored-by: Tomas R <tomas.roun8@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, ResourceReader was the suggested alternative, but it
is itself deprecated in favour of TraversableResources.
More discussion is here: #97850 (comment)
📚 Documentation preview 📚: https://cpython-previews--128601.org.readthedocs.build/