Repository navigation
gh-128807: Add marking phase for free-threaded cyclic GC - #128808
Merged
nascheme merged 20 commits intoJan 15, 2025
Merged
nascheme merged 20 commits into
nascheme merged 20 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
|
All commit authors signed the Contributor License Agreement. |
Sorry, something went wrong.
If the object is already marked as reachable, we shouldn't traverse it again.
These are not strictly needed, simplify PR.
More code cleanup (better names, comments, simplify error handling). Fix bug in that "alive" bit must be checked in mark_alive_stack_push() to avoid visiting already visited objects.
Make sure we still do this optimization. There is also a unit test that checks for this.
Reduces duplicate code.
nascheme
force-pushed
the
nogil-gc-mark-alive
branch
from
ccc5a11 to
680f80f
Compare
January 14, 2025 01:10
nascheme
marked this pull request as ready for review
January 14, 2025 18:12
colesbury
reviewed
Jan 14, 2025
colesbury
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks great! A few comments below
Sorry, something went wrong.
Comment thread
Python/gc_free_threading.c
Comment thread
Python/gc_free_threading.c
Comment thread
Python/gc_free_threading.c
Use gc_abort_mark_alive() helper in case of OOM. In addition to freeing the stack, we need to ensure that no object has the alive bit set on it. This also adding missing error handling in the case that propagate_alive_bits() fails.
Comment thread
Python/gc_free_threading.c
colesbury
approved these changes
Jan 15, 2025
colesbury
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is conceptually similar to the phase that was added to the non-free-threaded GC. Start with a set of known root objects, like sysdict and mark all objects reachable from those (revealed by the tp_traverse method) as "alive". We know anything marked alive cannot be garbage and can be excluded from the regular cyclic GC process. For most programs, this saves a moderate amount of computation since the marking pass is relatively cheaper per object.
If gc.freeze() is used, it's unlikely that this marking phase will be a win since it's expected that the majority of objects will be frozen. Disable the marking phase if freeze is used.
See gh-126491 for the non-free-threaded version of this technique.
pyperformance results vs merge base. I suspect the slowdown on some benchmarks is not real. For example, regex_v8 should not be slower.
Here are the pyperformance results for a bare-metal AMD Ryzen machine. It does not show a slowdown on regex_v8, for example.
To better show the expected improvement, I ran a "sphinx build" benchmark, like in gh-124567. Results are: