Repository navigation
gh-159137: Restore known-root marking for the GIL garbage collector - #159162
Closed
pablogsal wants to merge 1 commit into
Closed
pablogsal wants to merge 1 commit into
pablogsal wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
pablogsal
marked this pull request as ready for review
October 11, 2026 02:41
pablogsal
force-pushed
the
gh-159137-restore-gc-root-marking
branch
from
fa6d878 to
7bf0330
Compare
October 11, 2026 02:49
pablogsal
force-pushed
the
gh-159137-restore-gc-root-marking
branch
from
7bf0330 to
945ef05
Compare
October 11, 2026 03:07
Copy link
Copy Markdown
Member
Author
|
Closing this PR. I’ve learned that @brandtbucher's mentee has been working on something very close to this for a while and was planning to open source it once a few things cleared up. Rather than duplicate that effort, I’d prefer to focus on their work and help get it upstream, so I’ll be following up on that instead :) |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of gh-159137.
This brings back known-root marking for full collections in the GIL build. This was added it to the incremental collector in #127110, and it was removed when #148746 restored the generational collector. Excluding objects already known to be alive from trial reference counting is still useful without incremental collection. The free-threaded mark-alive pass in #128808 uses the same underlying idea.