Repository navigation
gh-127750: Restore inspect and pydoc support of singledispatchmethod - #130309
Merged
serhiy-storchaka merged 1 commit intoFeb 20, 2025
Merged
serhiy-storchaka merged 1 commit into
serhiy-storchaka merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…ethod The code is still flawed, because it does not recognize class and static methods, and the first argument is not removed from the signature of bound methods, but at least it does not worse than in 3.13 and older.
Copy link
Copy Markdown
Member
Author
|
This is a follow up of #130008. @AA-Turner, I do not know whether this is enough for Sphinx. If not, we will find other solution. Sphinx itself can use a workaround (in can_document_member()) similar to the code used for property, and it may even be more reliable, but we will try to not break old Sphinx. |
Sorry, something went wrong.
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Feb 20, 2025
…spatchmethod (pythonGH-130309) The code is still flawed, because it does not recognize class and static methods, and the first argument is not removed from the signature of bound methods, but at least it does not worse than in 3.13 and older. (cherry picked from commit 10b3205) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Feb 20, 2025
…ythonGH-130309) (cherry picked from commit 395335d) (cherry picked from commit 10b3205)
Copy link
Copy Markdown
|
GH-130340 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
serhiy-storchaka
added a commit
that referenced
this pull request
Feb 20, 2025
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 20, 2025
…ythonGH-130309) (pythonGH-130340) (cherry picked from commit 68c57d6) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> (cherry picked from commit 395335d) (cherry picked from commit 10b3205)
serhiy-storchaka
added a commit
that referenced
this pull request
Feb 20, 2025
johnslavik
reviewed
Jan 6, 2026
Comment thread
Lib/test/test_functools.py
johnslavik
added a commit
to johnslavik/cpython
that referenced
this pull request
Jan 7, 2026
This was referenced Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code is still flawed, because it does not recognize class and static methods, and the first argument is not removed from the signature of bound methods, but at least it does not worse than in 3.13 and older.