| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
@picnixz, could you please re-review? :) (The force-push was intentional; I know this is discouraged but I want to save noise, you can still follow what happened.) |
Sorry, something went wrong.
Documentation build overview20 files changed · ± 20 modified ± Modified |
Sorry, something went wrong.
There was a problem hiding this comment.
I'm not sure it's valuable to specifically disallow return annotations if we still allow dispatching by annotations on wrong parameters.
Sorry, something went wrong.
We could deprecate cases when the chosen parameter isn't the same as in my new formula. @picnixz prefers to just document the limitation. And when the deprecation ends, we break custom descriptors that emulate static method behavior (which nowadays seems less of a risk than I originally thought, case looks extremely rare and it's a trivial fix). |
Sorry, something went wrong.
Yeah, it's not very valuable. But in other cases we can't really be sure something is wrong, and the check is cheap. +0; I'd merge it. |
Sorry, something went wrong.
|
New deprecations should not get backported. The docs improvements will need manual backports. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
A very practical but more general approach than GH-140255 to fixing annotation parsing in functools.singledispatch and functools.singledispatchmethod.
Fixes issues GH-84644, GH-130827, and GH-143886.
It can be broken if one uses a user-defined alternative implementation of staticmethod or something analogous.
Will break incorrect but working registrees. I haven't investigated stripping Annotated typeforms yet.
Consulting a test which fails with this fix at https://github.com/python/cpython/pull/130309/changes#r2663516538 -- I think that the test is wrong.