Repository navigation

gh-84644: Fix singledispatch annotation parsing - #143465

Merged

encukou merged 108 commits into

python:mainfrom

johnslavik:fix-singledispatch-annotation-parsing

Oct 21, 2026

Merged

gh-84644: Fix singledispatch annotation parsing#143465
encukou merged 108 commits into
python:mainfrom
johnslavik:fix-singledispatch-annotation-parsing

Commits on Jan 6, 2026
- Resolve first positional param, required to be annotated
  johnslavik
  committed
  d3d6e64
- Special-case strings for forward refs similarly to typing
  johnslavik
  committed
  6ea2a4a
- Rename `ref_or_type` to `ref_or_typeform`
  johnslavik
  committed
  0a39278
- Add comment
  johnslavik
  committed
  096fc3b
- Shorten error message string line
  johnslavik
  committed
  c8a5cdc
- Adjust formatting to functools style
  johnslavik
  committed
  e1cde59
- Normalize `None` to a type, strip annotations
  johnslavik
  committed
  6bc698b
- Rename `ref_or_typeform` to `fwdref_or_typeform`
  johnslavik
  committed
  4ef7c7c
- Rename `skip_first` to `skip_first_param`
  johnslavik
  committed
  004c852
- Add news entry
  johnslavik
  committed
  9bc1436
- Add GH-130827 test
  johnslavik
  committed
  3115fd7
- Fix test
  johnslavik
  committed
  f6c102f
- Remove the `get_annotations` dance for now
  johnslavik
  committed
  7968570
Commits on Jan 7, 2026
- Fix incorrect `regster()` calls in `TestSingleDispatch.test_method_signatures`
  johnslavik
  committed
  a808a1e
- Fix string signatures accordingly
  johnslavik
  committed
  69b9978
- Raise exception if positional argument not found
  johnslavik
  committed
  ebdb68d
- Break the exception chain
  johnslavik
  committed
  8d86f9e
- Support all callables
  johnslavik
  committed
  82616f9
- Clarify comment
  johnslavik
  committed
  c9a1f1a
- Fiat lux, inline validation
  johnslavik
  committed
  e878207
- Add more test cases (mainly wrappers)
  johnslavik
  committed
  d3240a3
- More comments!
  johnslavik
  committed
  9240b0d
- Less history pollution
  johnslavik
  committed
  f6ccb97
- Document `_get_positional_param`
  johnslavik
  committed
  6642321
- Better comments!
  johnslavik
  committed
  0eaaa5b
- Shorten a comment
  johnslavik
  committed
  345b7e9
- Rephrase the fallback path comment
  johnslavik
  committed
  8a46f3f
- Improve the error message when missing an annotation
  johnslavik
  committed
  16f83ee
- Correct the docstring
  johnslavik
  committed
  552daaf
- Rephrase the documentation again
  johnslavik
  committed
  113cc29
- Rename the function to `_get_dispatch_param`
  johnslavik
  committed
  7c1bcea
- Rewrite the news entry using precise language
  johnslavik
  committed
  444425c
- Add a test for positional-only parameter
  johnslavik
  committed
  9b26fb1
- Add a mixed parameter types test case
  johnslavik
  committed
  17dfb36
- Do not break exception chain unnecessarily
  johnslavik
  committed
  fbce76d
- Improve the docstring
  johnslavik
  committed
  44b8bba
- Add precedent case for GH-84644
  johnslavik
  committed
  ec01821
- Fix GH-84644 test
  johnslavik
  authored
  57faa34
- Reword the documentation of `_get_dispatch_param`
  johnslavik
  authored
  e4fb514
- Merge GH-130827 test into `test_method_type_ann_register`
  johnslavik
  committed
  57965a9
- Add case this PR broke -- registering bound methods
  johnslavik
  committed
  eadc38f
- Add bound methods to slow path
  johnslavik
  committed
  682c41e
- Optimize instance checks in the fast path
  johnslavik
  committed
  c406755
- Use a match statement instead of a for loop
  johnslavik
  committed
  e238e6a
- Rewrite to a try-except
  johnslavik
  committed
  1e61429
- Improve comment
  johnslavik
  committed
  19458fc
- Add more bound method tests
  johnslavik
  committed
  6390a82
- Reuse one instance of test class
  johnslavik
  committed
  3e33040
- Test instance validity in bound method tests
  johnslavik
  committed
  c50d344
- Tests and fixes for staticmethod
  johnslavik
  committed
  32910f3
- Add more tests for classmethod
  johnslavik
  committed
  4283fba
Commits on Jan 8, 2026
- Disambiguate a comment
  johnslavik
  committed
  17b5088
- Always respect descriptors, fallback to assumptions on function-like objects
  johnslavik
  committed
  cdb7cca
- Add more comments
  johnslavik
  committed
  62088c7
- Specialcase bound methods in singledispatchmethods
  johnslavik
  committed
  c497857
- Finalize the logic
  johnslavik
  committed
  0f75d98
- Crystalize the decision tree
  johnslavik
  committed
  8350e71
- Fix comment
  johnslavik
  committed
  50c0e64
- Better comments
  johnslavik
  committed
  052c2fd
- Fiat lux
  johnslavik
  committed
  30994eb
- Rename function to `_get_singledispatch_annotated_param`
  johnslavik
  committed
  3edad44
- Disambiguate comment
  johnslavik
  committed
  fbc205e
- More comments
  johnslavik
  committed
  b691969
- Add more missing tests
  johnslavik
  committed
  0859bc0
- Cast the `idx` to an integer explicitly
  
  johnslavik
  and
  JelleZijlstra
  authored
  7ac8275
- Check param kinds by name (code review)
  johnslavik
  committed
  fbe00f8
- Minime the try-except
  johnslavik
  committed
  7ada2b0
- Remove all new tests
  johnslavik
  committed
  ac2f5a2
- Add previously failing tests only
  johnslavik
  committed
  ba46e43
Commits on Jan 12, 2026
- Merge branch 'main' into fix-singledispatch-annotation-parsing
  johnslavik
  committed
  3995e79
Commits on Jan 19, 2026
- Use imperative form in the docstring
  
  johnslavik
  and
  jaraco
  authored
  48d1bde
Commits on Jan 20, 2026
- Raise in `_get_singledispatch_annotated_param`
  
  johnslavik
  and
  jaraco
  committed
  fc5df46
- Rename the ugly `_inside_dispatchmethod` to `__role__`
  johnslavik
  committed
  7fcf4d5
- Hide private params from `.register` using `__text_signature__`
  johnslavik
  committed
  f7ec61d
- Remove comments that are sorta obvious
  johnslavik
  committed
  946ccb8
- Make the private helper tighter
  johnslavik
  committed
  2d1180a
- Condense fast path comment
  johnslavik
  committed
  cd10e91
- Bring back comments but make them actually helpful
  johnslavik
  committed
  0a622fb
- Another comment improvement
  johnslavik
  committed
  9b2d20d
- Fix incorrect comment
  johnslavik
  committed
  9191a22
- Restore old tests
  johnslavik
  committed
  ef74667
- Rework registration tests
  johnslavik
  committed
  b55de76
- Use stars for referring to param names
  johnslavik
  committed
  9977251
- Use `__role__` name only in the `register()` signature
  johnslavik
  committed
  d282c9a
- Denote the issues covered
  johnslavik
  committed
  4c43a9c
- Add regrtest from @pR0Ps
  
  pR0Ps
  and
  johnslavik
  committed
  3b5a410
- Somewhat better comment
  johnslavik
  committed
  f6ce233
Commits on Jan 22, 2026
- Merge branch 'main' into fix-singledispatch-annotation-parsing
  johnslavik
  authored
  97a8515
- Apply suggestion from @johnslavik
  johnslavik
  authored
  62ea333
Commits on Feb 8, 2026
- Final optional refinements
  johnslavik
  committed
  f0097c4
Commits on Feb 11, 2026
- Bring back `role` and `__role__`
  johnslavik
  committed
  4e6a003
Commits on Mar 1, 2026
- Fix code line length in `_get_singledispatch_annotated_param`
  johnslavik
  committed
  2d70e22
- Rename `__role__` to `_role` and make it kw-only
  johnslavik
  committed
  c716b57
- Fix missing param default in `__text_signature__`
  johnslavik
  committed
  a28e9af
- Change wording in news entry patch attribution
  
  johnslavik
  and
  picnixz
  authored
  cfb9194
- Rephrase the entire news entry
  johnslavik
  authored
  b03891f
- Finish up news entry corrections
  johnslavik
  committed
  4c8e818
- Apply more consistent formatting
  johnslavik
  committed
  7fa9315
- ...Actually readable formatting
  johnslavik
  committed
  cee055a
- Merge main to avoid conflict in the "What's New" entry
  johnslavik
  committed
  4db216f
- Rephrase the news entry again
  johnslavik
  committed
  cc2bcc7
- Add a what's new entry
  johnslavik
  committed
  371bff5
Commits on Jul 20, 2026
- Deprecate singledispatch registration by return annotation
  johnslavik
  committed
  a5a79ad
- Merge branch 'main' into fix-singledispatch-annotation-parsing
  johnslavik
  committed
  3dadb56
Commits on Jul 24, 2026
- Make warning clearer
  johnslavik
  committed
  0d0702e
- Use `__file__` for path skipping
  johnslavik
  committed
  b0ae4d1
Commits on Oct 19, 2026
- Address the review comments
  johnslavik
  committed
  bd65350
Commits on Oct 20, 2026
- Dedupe docs
  johnslavik
  committed
  37cd5a3

gh-84644: Fix singledispatch annotation parsing by johnslavik · Pull Request #143465 · python/cpython · GitHub

Repository navigation

gh-84644: Fix singledispatch annotation parsing - #143465

gh-84644: Fix singledispatch annotation parsing#143465encukou merged 108 commits intopython:mainpython/cpython:mainfrom johnslavik:fix-singledispatch-annotation-parsingjohnslavik/cpython:fix-singledispatch-annotation-parsingCopy head branch name to clipboard

Commits

Commits on Jan 6, 2026

Commits on Jan 7, 2026

Commits on Jan 8, 2026

Commits on Jan 12, 2026

Commits on Jan 19, 2026

Commits on Jan 20, 2026

Commits on Jan 22, 2026

Commits on Feb 8, 2026

Commits on Feb 11, 2026

Commits on Mar 1, 2026

Commits on Jul 20, 2026

Commits on Jul 24, 2026

Commits on Oct 19, 2026

Commits on Oct 20, 2026

gh-84644: Fix singledispatch annotation parsing#143465
encukou merged 108 commits into
python:mainfrom
johnslavik:fix-singledispatch-annotation-parsing