GH-125866: Deprecate nturl2path module - #131432
Merged
barneygale merged 8 commits intoMar 19, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Add `tests.test_nturl2path` to exercise `nturl2path`. `nturl2path` is currently used by `urllib` and tested by `test_urllib`, but that will change when we deprecate `nturl2path` and add support for Windows paths/URLs in `urllib` itself.
serhiy-storchaka
approved these changes
Mar 19, 2025
serhiy-storchaka
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM.
Sorry, something went wrong.
Comment thread
Lib/urllib/request.py
Outdated
Copy link
Copy Markdown
Contributor
|
I split out the nturl2path tests 8 months ago. This PR does more and includes it. Maybe I'll close my PR after this merge? |
Sorry, something went wrong.
zooba
reviewed
Mar 19, 2025
Comment thread
Lib/nturl2path.py
Outdated
Copy link
Copy Markdown
Contributor
Author
Thanks for the info - sorry I didn't spot your PR before. It looks like we arrived at a similar place. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecate the nturl2path module. Its functionality is merged into urllib.request.
Add tests.test_nturl2path to exercise nturl2path, as it's no longer covered by test_urllib.