FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Bump `urllib.request` to 3.14 by donbarbos · Pull Request #14062 · python/typeshed · GitHub

Bump urllib.request to 3.14 - #14062

Merged
srittau merged 3 commits into
python:mainfrom
donbarbos:bump-urllib-3.14
May 14, 2025
Merged

Bump urllib.request to 3.14#14062
srittau merged 3 commits into
python:mainfrom
donbarbos:bump-urllib-3.14

Conversation

Copy link
Copy Markdown
Contributor

I don't know if we have a way to show that module is deprecated, but nturl2path is deprecated: python/cpython#131432

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

donbarbos marked this pull request as ready for review May 14, 2025 08:10

srittau commented May 14, 2025
edited
Loading

Copy link
Copy Markdown
Collaborator

I don't know if we have a way to show that module is deprecated, but nturl2path is deprecated: python/cpython#131432

In theory something like this might work, but I think it's better to just add a comment to the top of the file:

@deprecated("...")
def __getattr__(name: str) -> Never: ...

Also this won't really generate a deprecation message, so not worth it.

srittau merged commit fc1ee8f into python:main May 14, 2025

donbarbos commented May 14, 2025
edited
Loading

Copy link
Copy Markdown
Contributor Author

Also this won't really generate a deprecation message, so not worth it.

What do you think about adding @deprecated for each module function? (this module have only 2 functions)

of course with sys.version_info check

srittau commented May 14, 2025

Copy link
Copy Markdown
Collaborator

Also this won't really generate a deprecation message, so not worth it.

What do you think about adding @deprecated for each module function? (this module have only 2 functions)

of course with sys.version_info check

That sounds like a good idea.

mmingyu pushed a commit to mmingyu/typeshed that referenced this pull request May 16, 2025
donbarbos deleted the bump-urllib-3.14 branch February 25, 2026 04:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL