FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-132159: Do not shadow user arguments in generated `__new__` by `@warnings.deprecated` by XuehaiPan · Pull Request #132160 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-132159: Do not shadow user arguments in generated __new__ by @warnings.deprecated - #132160

Merged
JelleZijlstra merged 2 commits into
python:mainfrom
XuehaiPan:deprecated-cls-pos-only
Apr 6, 2025
ConversationCommits (2)ChecksFiles changed
Merged

gh-132159: Do not shadow user arguments in generated __new__ by @warnings.deprecated#132160
JelleZijlstra merged 2 commits into
python:mainfrom
XuehaiPan:deprecated-cls-pos-only

Conversation

XuehaiPan commented Apr 6, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-app Bot mentioned this pull request Apr 6, 2025
Closed
JelleZijlstra approved these changes Apr 6, 2025
View reviewed changes

JelleZijlstra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

JelleZijlstra added the needs backport to 3.13 only security fixes label Apr 6, 2025
JelleZijlstra enabled auto-merge (squash) April 6, 2025 16:14
JelleZijlstra merged commit 7bb1e1a into python:main Apr 6, 2025

miss-islington-app Bot commented Apr 6, 2025

Copy link
Copy Markdown

Thanks @XuehaiPan for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 6, 2025
pythongh-132159: Do not shadow user arguments in generated __new__ …
d3af86c 
…by `@warnings.deprecated` (pythonGH-132160)

(cherry picked from commit 7bb1e1a)

Co-authored-by: Xuehai Pan <XuehaiPan@pku.edu.cn>

bedevere-app Bot commented Apr 6, 2025

Copy link
Copy Markdown

GH-132163 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label Apr 6, 2025
JelleZijlstra pushed a commit that referenced this pull request Apr 6, 2025
[3.13] gh-132159: Do not shadow user arguments in generated __new__…
83070aa 
… by `@warnings.deprecated` (GH-132160) (#132163)

gh-132159: Do not shadow user arguments in generated `__new__` by `@warnings.deprecated` (GH-132160)
(cherry picked from commit 7bb1e1a)

Co-authored-by: Xuehai Pan <XuehaiPan@pku.edu.cn>
XuehaiPan deleted the deprecated-cls-pos-only branch April 6, 2025 17:46
Viicos added a commit to Viicos/typing_extensions that referenced this pull request Apr 8, 2025
Do not shadow user arguments in generated __new__ by @deprecated
bae017a 
Backport of: python/cpython#132160
Viicos mentioned this pull request Apr 8, 2025
Merged
JelleZijlstra pushed a commit to python/typing_extensions that referenced this pull request Apr 10, 2025
Do not shadow user arguments in generated __new__ by @deprecated (#…
88a0c20 
…581)

Backport of: python/cpython#132160
campaigner-prod Bot mentioned this pull request Apr 23, 2026
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JelleZijlstra JelleZijlstra approved these changes
sobolevn sobolevn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Do not shadow user arguments in generated __new__ by @warnings.deprecated

3 participants

Back | FazBrowse Home | New Git URL