Do not shadow user arguments in generated __new__ by @deprecated - #581
Merged
JelleZijlstra merged 3 commits intoApr 10, 2025
Merged
JelleZijlstra merged 3 commits into
JelleZijlstra merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
The test fails because on versions where warnings.deprecated exists but not your fix, we use the stdlib version. This can be fixed by adjusting the condition for when we use the stdlib version. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Would you mind adding an entry to CHANGELOG.md? (I'd do it myself but then I'd have to ping somebody else to review.) |
Sorry, something went wrong.
JelleZijlstra
approved these changes
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of: python/cpython#132160