Repository navigation
gh-132308: TracebackException swallows attributes of falsey Exception and falsey ExceptionGroup - #132363
Merged
picnixz merged 16 commits intoApr 19, 2025
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Comment thread
Lib/test/test_traceback.py
Outdated
Comment thread
Misc/NEWS.d/next/Library/2025-04-10-13-06-42.gh-issue-132308.1js5SI.rst
Outdated
picnixz
reviewed
Apr 18, 2025
Comment thread
Lib/test/test_traceback.py
Outdated
Comment thread
Lib/test/test_traceback.py
Outdated
Comment thread
Misc/NEWS.d/next/Library/2025-04-10-13-06-42.gh-issue-132308.1js5SI.rst
Outdated
Comment thread
Lib/test/test_traceback.py
Comment thread
Lib/test/test_traceback.py
Outdated
picnixz
reviewed
Apr 19, 2025
Comment thread
Misc/NEWS.d/next/Library/2025-04-10-13-06-42.gh-issue-132308.1js5SI.rst
Outdated
picnixz
approved these changes
Apr 19, 2025
picnixz
reviewed
Apr 19, 2025
Comment thread
Misc/NEWS.d/next/Library/2025-04-10-13-06-42.gh-issue-132308.1js5SI.rst
Outdated
Copy link
Copy Markdown
Member
|
Yes, I forgot about it :') Thanks for the reminder |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 19, 2025
…f a falsey `Exception` or `ExceptionGroup` (pythonGH-132363) (cherry picked from commit 69cda31) Co-authored-by: Duprat <yduprat@gmail.com>
Copy link
Copy Markdown
|
GH-132725 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
No it's fine. I'm on my way to the airport, I'll merge it in a few hours. Thanks for the reminder! |
Sorry, something went wrong.
YvesDup
deleted the
TracebackException-swallows-cause-context-flasey-exception
branch
May 22, 2025 17:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An x is falsey if len(x) returns 0 or bool(x) returns False
TracebackException class swallows the following attributes of falsey Exception:
TracebackException swallows all sub-exceptions of falsey ExceptionGroup
The fix is located in the __init__ method of the TracebackException class.